New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix metadata for v11.8.0 doc changes #25709

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@richardlau
Copy link
Member

richardlau commented Jan 25, 2019

Refs: 641de82

cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Jan 25, 2019

See #25705 (comment). I'll leave it to @MylesBorins to decide if this PR should be folded into #25705.

@lpinca

lpinca approved these changes Jan 25, 2019

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 25, 2019

Please 👍 this comment to approve fast-tracking

@MylesBorins
Copy link
Member

MylesBorins left a comment

LGTM

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 26, 2019

Landed in bbb2134

@Trott Trott closed this Jan 26, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 26, 2019

doc: fix metadata for v11.8.0 doc changes
Refs: nodejs@641de82

PR-URL: nodejs#25709
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

doc: fix metadata for v11.8.0 doc changes
Refs: 641de82

PR-URL: #25709
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment