Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uppolicy: ensure workers do not read fs for policy #25710
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
process
worker
labels
Jan 25, 2019
bmeck
requested review from
addaleax
and
joyeecheung
Jan 25, 2019
addaleax
approved these changes
Jan 25, 2019
joyeecheung
approved these changes
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
addaleax
added
the
author ready
label
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
Landed in 7898238. |
danbev
closed this
Jan 29, 2019
bot
pushed a commit
to zys-contribs/node
that referenced
this pull request
Jan 29, 2019
added a commit
that referenced
this pull request
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bmeck commentedJan 25, 2019
This prevents a main thread from rewriting the policy file and loading
a worker that has a different policy from the main thread.
This prevents a main file of:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes