New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove pummel/test-exec #25722

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Trott
Copy link
Member

Trott commented Jan 26, 2019

Remove redundant test/pummel/test-exec.js.

Refs: #25686 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: remove pummel/test-exec
Remove redundant test/pummel/test-exec.js.

Refs: #25686 (review)

@Trott Trott requested a review from Fishrock123 Jan 26, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 27, 2019

@Trott Trott added the author ready label Jan 27, 2019

@lpinca

lpinca approved these changes Jan 27, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 28, 2019

Landed in 953dae1

@Trott Trott closed this Jan 28, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 28, 2019

test: remove pummel/test-exec
Remove redundant test/pummel/test-exec.js.

Refs: nodejs#25686 (review)

PR-URL: nodejs#25722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott referenced this pull request Jan 28, 2019

Closed

test: move test-exec.js out of pummel #25686

2 of 2 tasks complete

addaleax added a commit that referenced this pull request Jan 28, 2019

test: remove pummel/test-exec
Remove redundant test/pummel/test-exec.js.

Refs: #25686 (review)

PR-URL: #25722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment