New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused field in node_http2.h #25727

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@gengjiawen
Copy link
Contributor

gengjiawen commented Jan 26, 2019

The field is no longer needed after this refactor: 0625627.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
src: remove unused field in node_http2.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@addaleax

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Jan 29, 2019

Landed in d4d76b6.

@danbev danbev closed this Jan 29, 2019

danbev added a commit that referenced this pull request Jan 29, 2019

src: remove unused field in node_http2.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25727
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jan 29, 2019

src: remove unused field in node_http2.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25727
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment