New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make trailing commas consistent in .eslintrc #25739

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Trott
Copy link
Member

Trott commented Jan 27, 2019

.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
tools: make trailing commas consistent in .eslintrc
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.
@targos

targos approved these changes Jan 27, 2019

@Trott Trott added the author ready label Jan 27, 2019

@lpinca

lpinca approved these changes Jan 27, 2019

@devsnek
Copy link
Member

devsnek left a comment

if only we could do this to the whole codebase 😢

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 27, 2019

if only we could do this to the whole codebase 😢

soon

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 29, 2019

Landed in 1a37fd6

@addaleax addaleax closed this Jan 29, 2019

pull bot pushed a commit to zys-contribs/node that referenced this pull request Jan 29, 2019

tools: make trailing commas consistent in .eslintrc
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.

PR-URL: nodejs#25739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

targos added a commit that referenced this pull request Jan 29, 2019

tools: make trailing commas consistent in .eslintrc
.eslintrc has lots of trailing commas and lots of places where there
aren't trailing commas. Use trailing commas throughout the files for
consistency.

PR-URL: #25739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment