New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-http-client-timeout-option-with-agent #25752

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Trott
Copy link
Member

Trott commented Jan 28, 2019

  • Switch from Date.now() to process.hrtime.bigint().
  • Move start time recording to before the request is created, not after.

Fixes: #25746

@devsnek @nodejs/http @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: refactor test-http-client-timeout-option-with-agent
* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: #25746
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 28, 2019

@Trott Trott added the author ready label Jan 28, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Jan 30, 2019

Landed in b897704

Trott added a commit to Trott/io.js that referenced this pull request Jan 30, 2019

test: refactor test-http-client-timeout-option-with-agent
* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: nodejs#25746

PR-URL: nodejs#25752
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Trott Trott closed this Jan 30, 2019

targos added a commit that referenced this pull request Jan 30, 2019

test: refactor test-http-client-timeout-option-with-agent
* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: #25746

PR-URL: #25752
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment