New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test/common/report.js #25754

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
6 participants
@cjihrig
Copy link
Contributor

cjihrig commented Jan 28, 2019

  • Don't unnecessarily require('../common').
  • Eliminate state maintained in tmppath.
  • validate() was being used synchronously, but was actually asynchronous. Make it synchronous.
  • Other misc. drive by cleanup.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Jan 30, 2019

test: refactor test/common/report.js
- Don't unnecessarily require('../common').
- Eliminate state maintained in tmppath.
- validate() was being used synchronously, but was actually
  asynchronous. Make it synchronous.
- Other misc. drive by cleanup.

PR-URL: #25754
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@cjihrig cjihrig force-pushed the cjihrig:common-report branch from d78bb80 to c64b1ae Jan 30, 2019

@cjihrig cjihrig merged commit c64b1ae into nodejs:master Jan 30, 2019

targos added a commit that referenced this pull request Jan 30, 2019

test: refactor test/common/report.js
- Don't unnecessarily require('../common').
- Eliminate state maintained in tmppath.
- validate() was being used synchronously, but was actually
  asynchronous. Make it synchronous.
- Other misc. drive by cleanup.

PR-URL: #25754
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment