Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update prerequisites on progress towards Python 3 #25766

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
8 participants
@cclauss
Copy link
Contributor

commented Jan 28, 2019

As recommended at #25759 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
build: update prerequisites on progress towards Python 3
As recommended at #25759 (comment)
* Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan
* Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update
* Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus

@cclauss cclauss referenced this pull request Jan 28, 2019

Closed

build: PYTHON ?= python3 #25759

1 of 4 tasks complete
Show resolved Hide resolved BUILDING.md Outdated

cclauss added some commits Jan 28, 2019

Show resolved Hide resolved BUILDING.md Outdated
@Trott

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

@Trott

This comment has been minimized.

Link up to Prerequisites
Co-Authored-By: cclauss <cclauss@me.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

@Trott

This comment has been minimized.

@refack

refack approved these changes Jan 29, 2019

@refack refack added the semver-major label Jan 29, 2019

@refack

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

LGTM as a semver-major move for node12

@refack refack added the python label Jan 29, 2019

@Trott

Trott approved these changes Jan 29, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@ofrobots

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

This is a FYI doc-only change. Why is this semver-major?

@refack

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Why is this semver-major?

I think that a formal change in supported toolchains (i.e. no longer supporting Python2.6) should be semver-major.
Effectively this frees us to break compatibility with 2.6, and to stop testing with 2.6.

@ofrobots
Copy link
Contributor

left a comment

Ack. I missed the 2.6 drop the first time around. Sorry about that.

LGTM.

@refack

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

I think semver-major/"breaking change" should be applied only to things that might break stuff for the end user.

FWIW, some end users do compile their own binary, and some users are downstream consumers in some way (embedders / tinkerers), so in that sense a change in the toolchain could break their usage.

@refack refack self-assigned this Jan 30, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Even though this is going in as semver-major, I imagine we don't need a CITGM run for this, so I'll add the author ready label.

@Trott Trott added the author ready label Jan 30, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Landed in bb564a3

@addaleax addaleax closed this Jan 30, 2019

addaleax added a commit that referenced this pull request Jan 30, 2019

build: update prerequisites on progress towards Python 3
As recommended at #25759 (comment)
* Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan
* Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update
* Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus

PR-URL: #25766
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@cclauss cclauss deleted the cclauss:patch-3 branch Jan 30, 2019

@refack refack removed their assignment Mar 11, 2019

@BethGriggs BethGriggs referenced this pull request Mar 26, 2019

Merged

v12.0.0 proposal #26930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.