New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused env_ field from env.h #25784

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@danbev
Copy link
Member

danbev commented Jan 29, 2019

Currently the following compiler warnings is generated:

In file included from ../src/env-inl.h:28:
../src/env.h:521:18:
warning: private field 'env_' is not used [-Wunused-private-field]
    Environment* env_;
                 ^
1 warning generated.

This commit removes this unused field.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: removed unused env_ field from env.h
Currently the following compiler warnings is generated:
In file included from ../src/env-inl.h:28:
../src/env.h:521:18:
warning: private field 'env_' is not used [-Wunused-private-field]
    Environment* env_;
                 ^
1 warning generated.

This commit removes this unused field.
@danbev

This comment has been minimized.

Copy link
Member Author

danbev commented Jan 29, 2019

@danbev

This comment has been minimized.

Copy link
Member Author

danbev commented Jan 29, 2019

Re-run of failing node-test-commit-linux (✔️)

@danbev danbev added the fast-track label Jan 29, 2019

@danbev

This comment has been minimized.

Copy link
Member Author

danbev commented Jan 29, 2019

Please give a 👍 if you think this can be fast-tracked, or if you disagree please remove the fast-track label.

@refack

refack approved these changes Jan 30, 2019

@refack

This comment has been minimized.

@danbev danbev changed the title src: removed unused env_ field from env.h src: remove unused env_ field from env.h Jan 30, 2019

danbev added a commit that referenced this pull request Jan 30, 2019

src: remove unused env_ field from env.h
Currently the following compiler warnings is generated:
In file included from ../src/env-inl.h:28:
../src/env.h:521:18:
warning: private field 'env_' is not used [-Wunused-private-field]
    Environment* env_;
                 ^
1 warning generated.

This commit removes this unused field.

PR-URL: #25784
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

danbev commented Jan 30, 2019

Landed in dd682ce.

@refack Thanks for running CI! It was run and then I only re-ran the failing one, so I think this PR is fully covered by CI even though the UI was/is marked as red.

@danbev danbev closed this Jan 30, 2019

@danbev danbev deleted the danbev:env_unused_var branch Jan 30, 2019

targos added a commit that referenced this pull request Jan 30, 2019

src: remove unused env_ field from env.h
Currently the following compiler warnings is generated:
In file included from ../src/env-inl.h:28:
../src/env.h:521:18:
warning: private field 'env_' is not used [-Wunused-private-field]
    Environment* env_;
                 ^
1 warning generated.

This commit removes this unused field.

PR-URL: #25784
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment