Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: fix error check in `Execute()` #25863

Closed
wants to merge 1 commit into
base: v10.x-staging
from

Conversation

Projects
None yet
5 participants
@mscdex
Copy link
Contributor

mscdex commented Feb 1, 2019

Refs: #24738
Fixes: #25858

CI: https://ci.nodejs.org/job/node-test-pull-request/20501/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added the http label Feb 1, 2019

@mscdex

This comment has been minimized.

Copy link
Contributor Author

mscdex commented Feb 1, 2019

/cc @indutny

@indutny

This comment has been minimized.

Copy link
Member

indutny commented Feb 1, 2019

@mscdex There're differences in return values for llhttp and http_parser. I don't think that this PR as it is will work well for llhttp.

cc @addaleax

@indutny

This comment has been minimized.

Copy link
Member

indutny commented Feb 1, 2019

Wait, I just realized that this is for 10.x branch. nvm.

@indutny

indutny approved these changes Feb 1, 2019

Copy link
Member

indutny left a comment

LGTM

@mscdex

This comment has been minimized.

Copy link
Contributor Author

mscdex commented Feb 5, 2019

@mcollina
Copy link
Member

mcollina left a comment

LGTM. Does this apply only on Node 10?

@mscdex

This comment has been minimized.

Copy link
Contributor Author

mscdex commented Feb 5, 2019

@mcollina It has to be done for v6.x and v8.x as well if that's what you mean, I can do that yet. master already has the fix though.

@mscdex

This comment has been minimized.

Copy link
Contributor Author

mscdex commented Feb 5, 2019

PR for v6.x: #25939
PR for v8.x: #25938

BethGriggs added a commit that referenced this pull request Feb 5, 2019

http: fix error check in `Execute()`
Refs: #24738
Fixes: #25858

PR-URL: #25863
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BethGriggs

This comment has been minimized.

Copy link
Member

BethGriggs commented Feb 5, 2019

Landed on v10.x-staging in 741c5ef

@BethGriggs BethGriggs closed this Feb 5, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

http: fix error check in `Execute()`
Refs: #24738
Fixes: #25858

PR-URL: #25863
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

BethGriggs added a commit that referenced this pull request Mar 4, 2019

2019-03-05, Version 10.15.3 'Dubnium' (LTS)
Notable Changes

* **doc**
  * add antsmartian to collaborators (Anto Aravinth)
    [#24655](#24655)
* **http**
  * fix error check in Execute() (Brian White)
    [#25863](#25863)
* **stream**
  * fix end-of-stream for HTTP/2 (Anna Henningsen)
    [#24926](#24926)

PR-URL: #26063

BethGriggs added a commit that referenced this pull request Mar 5, 2019

2019-03-05, Version 10.15.3 'Dubnium' (LTS)
Notable Changes

* **doc**
  * add antsmartian to collaborators (Anto Aravinth)
    [#24655](#24655)
* **http**
  * fix error check in Execute() (Brian White)
    [#25863](#25863)
* **stream**
  * fix end-of-stream for HTTP/2 (Anna Henningsen)
    [#24926](#24926)

PR-URL: #26063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.