Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not fail SLOW tests if they are not slow #25868

Closed
wants to merge 1 commit into from

Conversation

@hashseed
Copy link
Member

hashseed commented Feb 1, 2019

Make SLOW imply PASS.

Refs: #25867

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@hashseed hashseed requested review from refack and addaleax Feb 1, 2019
@richardlau richardlau mentioned this pull request Feb 1, 2019
2 of 2 tasks complete
@danbev
danbev approved these changes Feb 1, 2019
@refack
refack approved these changes Feb 1, 2019
@addaleax

This comment has been minimized.

@devsnek
devsnek approved these changes Feb 2, 2019
@hashseed

This comment has been minimized.

Copy link
Member Author

hashseed commented Feb 4, 2019

Looks like some Jenkins related issue?

@refack

This comment has been minimized.

Copy link
Member

refack commented Feb 4, 2019

Looks like some Jenkins related issue?

Should be solved.
Resume: https://ci.nodejs.org/job/node-test-pull-request/20562/ ✔️

@refack refack added landed and removed author ready labels Feb 4, 2019
@refack

This comment has been minimized.

Copy link
Member

refack commented Feb 4, 2019

Landed in dfe5f8f

@refack refack closed this Feb 4, 2019
refack added a commit that referenced this pull request Feb 4, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Feb 6, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Feb 14, 2019
@hashseed hashseed deleted the hashseed:slowtests branch Feb 15, 2019
BethGriggs added a commit that referenced this pull request Dec 4, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.