Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make deleted function public in agent.h #25909

Closed

Conversation

Projects
None yet
4 participants
@gengjiawen
Copy link
Contributor

commented Feb 3, 2019

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: make deleted function public in agent.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@bnoordhuis
Copy link
Member

left a comment

LGTM but can you explain why in the commit log? This is like your other PR, right?

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

@bnoordhuis not quite sure which part you mean.I check the commit log, looks like right to me.

@danbev

danbev approved these changes Feb 6, 2019

@danbev

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Re-run of failing node-test-commit-arm/

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@danbev Do I need to rebase my code ?

@danbev

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@danbev Do I need to rebase my code ?

I don't thinks so, I've re-run the failing build once more and it now passes:
https://ci.nodejs.org/job/node-test-commit-arm/22021/

@danbev

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Landed in 3a02d39.

@danbev danbev closed this Feb 8, 2019

danbev added a commit that referenced this pull request Feb 8, 2019

src: make deleted function public in agent.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

addaleax added a commit that referenced this pull request Feb 8, 2019

src: make deleted function public in agent.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.