Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove redundant call to socket.setTimeout() #25928

Closed
wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

commented Feb 4, 2019

Socket.prototype.setTimeout() clears the previous timer before setting
a new one.

Refs: #25748 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
http: remove redundant call to socket.setTimeout()
`Socket.prototype.setTimeout()` clears the previous timer before setting
a new one.

Refs: #25748 (comment)
@lpinca

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@lpinca lpinca added the author ready label Feb 5, 2019

@cjihrig
cjihrig approved these changes Feb 5, 2019
@jasnell
jasnell approved these changes Feb 5, 2019
@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Landed in cc5de5a

@addaleax addaleax closed this Feb 6, 2019

addaleax added a commit that referenced this pull request Feb 6, 2019
http: remove redundant call to socket.setTimeout()
`Socket.prototype.setTimeout()` clears the previous timer before setting
a new one.

Refs: #25748 (comment)

PR-URL: #25928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Feb 6, 2019
http: remove redundant call to socket.setTimeout()
`Socket.prototype.setTimeout()` clears the previous timer before setting
a new one.

Refs: #25748 (comment)

PR-URL: #25928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@lpinca lpinca deleted the lpinca:remove/redundant-set-timeout branch Feb 7, 2019

@targos targos referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.