Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: null not valid as a renegotiate callback #25929

Closed

Conversation

Projects
9 participants
@sam-github
Copy link
Member

commented Feb 4, 2019

Allow undefined as a callback, but do not allow null.

Belatedly respond to #25876 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
tls: null not valid as a renegotiate callback
Allow undefined as a callback, but do not allow null.

@sam-github sam-github requested a review from cjihrig Feb 4, 2019

@cjihrig

cjihrig approved these changes Feb 4, 2019

@lpinca

lpinca approved these changes Feb 5, 2019

@jasnell

jasnell approved these changes Feb 5, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Landed in 00d49ad

@addaleax addaleax closed this Feb 6, 2019

addaleax added a commit that referenced this pull request Feb 6, 2019

tls: null not valid as a renegotiate callback
Allow undefined as a callback, but do not allow null.

PR-URL: #25929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

sam-github added a commit to sam-github/node that referenced this pull request Feb 6, 2019

tls: null not valid as a renegotiate callback
Allow undefined as a callback, but do not allow null.

PR-URL: nodejs#25929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

sam-github added a commit to sam-github/node that referenced this pull request Feb 6, 2019

tls: null not valid as a renegotiate callback
Allow undefined as a callback, but do not allow null.

Backport-PR-URL: nodejs#25968
PR-URL: nodejs#25929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@sam-github sam-github referenced this pull request Feb 6, 2019

Closed

[v11.x backport] tls cleanups #25968

0 of 4 tasks complete

@sam-github sam-github deleted the sam-github:only-undef-or-fn-for-reneg branch Feb 6, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@sam-github If I understood you correctly, this should be labelled dont-land-on-v11.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.