Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] http: fix error check in `Execute()` #25939

Conversation

Projects
None yet
5 participants
@mscdex
Copy link
Contributor

commented Feb 5, 2019

Refs: #24738
Fixes: #25858

CI: https://ci.nodejs.org/job/node-test-pull-request/20578/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added the http label Feb 5, 2019

@mscdex mscdex referenced this pull request Feb 5, 2019

Closed

http: fix error check in `Execute()` #25863

3 of 3 tasks complete
@jasnell

jasnell approved these changes Feb 5, 2019

@addaleax addaleax changed the title http: fix error check in `Execute()` [v6.x] http: fix error check in `Execute()` Feb 9, 2019

@rvagg rvagg force-pushed the nodejs:v6.x-staging branch from e2faf8c to 2948c07 Feb 28, 2019

@mscdex mscdex force-pushed the mscdex:v6-http-fix-parser-execute-error-check branch from 084ccb3 to 41f8dd5 Feb 28, 2019

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@BethGriggs BethGriggs force-pushed the nodejs:v6.x-staging branch from 2948c07 to b5d4649 Mar 7, 2019

@lpinca

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

@mscdex I think this needs a rebase.

@mscdex mscdex force-pushed the mscdex:v6-http-fix-parser-execute-error-check branch from 41f8dd5 to 858004a Mar 9, 2019

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

@lpinca Done.

@lpinca

lpinca approved these changes Mar 9, 2019

@lpinca

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

@BethGriggs

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

BethGriggs added a commit that referenced this pull request Mar 11, 2019

http: fix error check in `Execute()`
Refs: #24738
Fixes: #25858

PR-URL: #25939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Landed in 8080a9b

@BethGriggs BethGriggs closed this Mar 11, 2019

@mscdex mscdex deleted the mscdex:v6-http-fix-parser-execute-error-check branch Mar 11, 2019

BethGriggs added a commit that referenced this pull request Mar 15, 2019

2019-04-02, Version 6.17.1 'Boron' (LTS)
Notable changes:

* **http**:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

@BethGriggs BethGriggs referenced this pull request Mar 15, 2019

Merged

v6.17.1 proposal #26684

BethGriggs added a commit that referenced this pull request Mar 15, 2019

2019-04-02, Version 6.17.1 'Boron' (LTS)
Notable changes:

* **http**:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

BethGriggs added a commit that referenced this pull request Mar 19, 2019

2019-04-02, Version 6.17.1 'Boron' (LTS)
Notable changes:

* **http**:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

BethGriggs added a commit that referenced this pull request Apr 2, 2019

2019-04-02, Version 6.17.1 'Boron' (LTS)
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

BethGriggs added a commit that referenced this pull request Apr 3, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684

BethGriggs added a commit that referenced this pull request Apr 3, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684

BethGriggs added a commit that referenced this pull request Apr 3, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684

BethGriggs added a commit that referenced this pull request Apr 4, 2019

2019-04-03, Version 6.17.1 'Boron' (LTS)
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.