Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win, build: arm64 port script and doc changes #25995

Closed
wants to merge 4 commits into from

Conversation

@jkunkee
Copy link
Contributor

commented Feb 7, 2019

This change lays the groundwork for ARM64 Windows ("Windows 10 on ARM") builds of Node.js.

Build script and configuration files gets new ARM64 Windows sections. The arch-specific check for NASM is scoped to the architectures that rely on it.

The bootstrap script arguments for Visual Studio tool installation are expanded to include ARM64 tools.

Documentation is updated to reflect all of these changes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • ARM64 vcbuild requires other changes, but Windows x64 passes.
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jkunkee jkunkee force-pushed the jkunkee:arm64-win-build branch 2 times, most recently from 6d4196a to c1f2ce5 Feb 7, 2019

configure.py Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
@jkunkee jkunkee referenced this pull request Feb 8, 2019
2 of 2 tasks complete
@vielmetti

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

@jkunkee - talk to me about what you might need for arm64 CI/CD for Windows 10? (perhaps offline, perhaps here) I have some resources through @WorksOnArm but we don't yet have Windows 10 for Arm up on any servers.

@jkunkee

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@vielmetti, in general we need machines--virtual or physical--running Windows 10 on ARM and available on demand as a service for the general public. I'll ping you via email about it.

BUILDING.md Outdated Show resolved Hide resolved

@jkunkee jkunkee force-pushed the jkunkee:arm64-win-build branch 2 times, most recently from 3c65a55 to 333ea47 Feb 15, 2019

@jkunkee jkunkee force-pushed the jkunkee:arm64-win-build branch 2 times, most recently from 1abe49f to 7083224 Feb 20, 2019

@jkunkee jkunkee force-pushed the jkunkee:arm64-win-build branch from 7083224 to 735d376 Feb 20, 2019

@joaocgreis

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

joaocgreis added a commit that referenced this pull request Mar 4, 2019
win,build: add ARM64 support to vcbuild.bat
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
joaocgreis added a commit that referenced this pull request Mar 4, 2019
win,build: add ARM64 sections to common.gypi
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
joaocgreis added a commit that referenced this pull request Mar 4, 2019
win,build: scope NASM warning to only x64 and x86
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
joaocgreis added a commit that referenced this pull request Mar 4, 2019
win,build: update Windows build documentation
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
@joaocgreis

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Landed in d57c526...26cfaf4
Thanks @jkunkee!

@joaocgreis joaocgreis closed this Mar 4, 2019

@jkunkee jkunkee deleted the jkunkee:arm64-win-build branch Mar 8, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
win,build: add ARM64 support to vcbuild.bat
PR-URL: nodejs#25995
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
win,build: add ARM64 sections to common.gypi
PR-URL: nodejs#25995
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
win,build: scope NASM warning to only x64 and x86
PR-URL: nodejs#25995
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
win,build: update Windows build documentation
PR-URL: nodejs#25995
Reviewed-By: João Reis <reis@janeasystems.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
win,build: add ARM64 support to vcbuild.bat
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
win,build: add ARM64 sections to common.gypi
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
win,build: scope NASM warning to only x64 and x86
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
win,build: update Windows build documentation
PR-URL: #25995
Reviewed-By: João Reis <reis@janeasystems.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.