Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: make more items programmatically accessible #26019

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 9, 2019

Prefer structured output over stringified information
for libuv handles and the native stack trace.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Prefer structured output over stringified information
for libuv handles and the native stack trace.
@addaleax addaleax requested a review from cjihrig February 9, 2019 23:13
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 9, 2019
@addaleax addaleax assigned addaleax and unassigned addaleax Feb 9, 2019
@addaleax addaleax added the report Issues and PRs related to process.report. label Feb 9, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20700/ (:heavy_check_mark:)

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Side note - keeping the example report in the docs up to date is becoming a bit of a pain 😄

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member Author

Landed in 2c84f6e

@addaleax addaleax closed this Feb 11, 2019
@addaleax addaleax deleted the report-prog branch February 11, 2019 23:56
addaleax added a commit that referenced this pull request Feb 11, 2019
Prefer structured output over stringified information
for libuv handles and the native stack trace.

PR-URL: #26019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Feb 13, 2019
Prefer structured output over stringified information
for libuv handles and the native stack trace.

PR-URL: #26019
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants