Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage for assertion_error.js #26065

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Trott
Copy link
Member

commented Feb 13, 2019

Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

This introduces coverage for https://coverage.nodejs.org/coverage-0a4c69a5c5e8ba93/lib/internal/assert/assertion_error.js.html#L370.

I standardized nearby arrow functions to use braces when they are not intended to return a value.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

@Trott Trott changed the title test: increase coverage for assertione_error.js test: increase coverage for assertion_error.js Feb 13, 2019

@Trott Trott force-pushed the Trott:1024-coverage branch from 87159cf to 43bd45e Feb 13, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

Edited the commit message and force-pushed. CI: https://ci.nodejs.org/job/node-test-pull-request/20757/

@Trott Trott force-pushed the Trott:1024-coverage branch from 43bd45e to 398bb79 Feb 13, 2019

test: increase coverage for assertion_error.js
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

@Trott Trott force-pushed the Trott:1024-coverage branch from 398bb79 to fc526a9 Feb 13, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

@Trott Trott added the author ready label Feb 13, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

Landed in 8e68dc5

@Trott Trott closed this Feb 15, 2019

Trott added a commit to Trott/io.js that referenced this pull request Feb 15, 2019

test: increase coverage for assertion_error.js
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

PR-URL: nodejs#26065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

targos added a commit that referenced this pull request Feb 15, 2019

test: increase coverage for assertion_error.js
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

PR-URL: #26065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

test: increase coverage for assertion_error.js
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

PR-URL: #26065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.