Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: consolidate N-API material in Colalborator Guide #26094

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Trott
Copy link
Member

commented Feb 14, 2019

Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: consolidate N-API material in Colalborator Guide
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

@Trott Trott added the author ready label Feb 14, 2019

@bengl

bengl approved these changes Feb 16, 2019

Trott added a commit to Trott/io.js that referenced this pull request Feb 16, 2019

doc: consolidate N-API material in Collaborator Guide
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: nodejs#26094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2019

Landed in 5bb7764

@Trott Trott closed this Feb 16, 2019

addaleax added a commit that referenced this pull request Feb 17, 2019

doc: consolidate N-API material in Collaborator Guide
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: #26094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

doc: consolidate N-API material in Collaborator Guide
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: #26094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.