Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: ignore --abort-on-uncaught-exception for terminate() #26111

Closed

Conversation

Projects
None yet
4 participants
@addaleax
Copy link
Member

commented Feb 14, 2019

When running Worker threads with --abort-on-uncaught-exception,
do not abort the process when worker.terminate() is called.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
worker: ignore --abort-on-uncaught-exception for terminate()
When running Worker threads with `--abort-on-uncaught-exception`,
do not abort the process when `worker.terminate()` is called.

@addaleax addaleax added the worker label Feb 14, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

Landed in 85b95cc

@addaleax addaleax closed this Feb 18, 2019

@addaleax addaleax deleted the addaleax:worker-termination-abort-on-uncaught branch Feb 18, 2019

addaleax added a commit that referenced this pull request Feb 18, 2019

worker: ignore --abort-on-uncaught-exception for terminate()
When running Worker threads with `--abort-on-uncaught-exception`,
do not abort the process when `worker.terminate()` is called.

PR-URL: #26111
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit that referenced this pull request Feb 18, 2019

worker: ignore --abort-on-uncaught-exception for terminate()
When running Worker threads with `--abort-on-uncaught-exception`,
do not abort the process when `worker.terminate()` is called.

PR-URL: #26111
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

worker: ignore --abort-on-uncaught-exception for terminate()
When running Worker threads with `--abort-on-uncaught-exception`,
do not abort the process when `worker.terminate()` is called.

PR-URL: #26111
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.