Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage of node_report_module.cc #26116

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
7 participants
@richardlau
Copy link
Member

commented Feb 14, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@Trott

Trott approved these changes Feb 15, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

test: increase coverage of node_report_module.cc
PR-URL: #26116
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@richardlau richardlau force-pushed the richardlau:reportmodulecov branch from 50cf1d7 to 146868c Feb 18, 2019

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

Landed in 146868c.

@richardlau richardlau merged commit 146868c into nodejs:master Feb 18, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

addaleax added a commit that referenced this pull request Feb 19, 2019

test: increase coverage of node_report_module.cc
PR-URL: #26116
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

test: increase coverage of node_report_module.cc
PR-URL: #26116
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.