Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: make _read() be called indefinitely if the user wants so #26135

Closed
wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

commented Feb 15, 2019

Fixes: #26097

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mcollina mcollina requested review from mafintosh and lpinca Feb 15, 2019

@lpinca
lpinca approved these changes Feb 15, 2019
@lpinca

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

SGTM , is it possible to add a test?

@lpinca

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

nvm, it's there I'm blind :)

@addaleax

This comment has been minimized.

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

@mcollina

This comment has been minimized.

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

@nodejs/build can you take a look why the benchmarking jobs are broken?

@richardlau

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@nodejs/build can you take a look why the benchmarking jobs are broken?

Issue was reported: nodejs/build#1690

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@nodejs/build can you take a look why the benchmarking jobs are broken?

I've been running benchmarks locally and pasting the results into issues as necessary. It is onerous for sure and I would not blame you at all for waiting until the benchmarking job is fixed. But if you're eager to move forward....

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

Here is the one on streams:

$ cat stream-infinite-loop.csv | Rscript benchmark/compare.R
                                                       confidence improvement accuracy (*)   (**)  (***)
 streams/creation.js kind='duplex' n=50000000                         -0.04 %       ±0.89% ±1.18% ±1.54%
 streams/creation.js kind='readable' n=50000000                       -0.16 %       ±0.39% ±0.51% ±0.67%
 streams/creation.js kind='transform' n=50000000                      -0.50 %       ±1.39% ±1.85% ±2.41%
 streams/creation.js kind='writable' n=50000000                       -0.18 %       ±0.86% ±1.14% ±1.49%
 streams/pipe-object-mode.js n=5000000                                 0.08 %       ±0.69% ±0.92% ±1.20%
 streams/pipe.js n=5000000                                             0.32 %       ±0.62% ±0.83% ±1.08%
 streams/readable-bigread.js n=1000                             *     -1.38 %       ±1.30% ±1.74% ±2.30%
 streams/readable-bigunevenread.js n=1000                             -0.29 %       ±0.57% ±0.76% ±1.00%
 streams/readable-boundaryread.js type='buffer' n=2000                 0.14 %       ±1.57% ±2.09% ±2.73%
 streams/readable-boundaryread.js type='string' n=2000                 0.34 %       ±1.87% ±2.49% ±3.24%
 streams/readable-readall.js n=5000                                   -1.00 %       ±1.56% ±2.08% ±2.71%
 streams/readable-unevenread.js n=1000                                -0.07 %       ±0.50% ±0.67% ±0.88%
 streams/writable-manywrites.js n=2000000                              0.10 %       ±0.70% ±0.93% ±1.21%
@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

@mafintosh

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

LGTM

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

This can land when CI gets back online.

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

Landed in cd302d7

@mcollina mcollina closed this Feb 28, 2019

@mcollina mcollina deleted the mcollina:fix-read-infinite-loop branch Feb 28, 2019

pull bot pushed a commit to zys-contribs/node that referenced this pull request Feb 28, 2019
stream: make _read() be called indefinitely if the user wants so
Fixes: nodejs#26097

PR-URL: nodejs#26135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit that referenced this pull request Mar 1, 2019
stream: make _read() be called indefinitely if the user wants so
Fixes: #26097

PR-URL: #26135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Mar 4, 2019
@fjsousa

This comment has been minimized.

Copy link

commented Apr 9, 2019

Issue #26097 affects node >=10.0.0. Are there any plans of releasing this fix in the next node 10 release?

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

@nodejs/lts would you mind including this in the next semver-patch of v10.x?

BethGriggs added a commit that referenced this pull request Jul 9, 2019
stream: make _read() be called indefinitely if the user wants so
Fixes: #26097

PR-URL: #26135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Jul 17, 2019
stream: make _read() be called indefinitely if the user wants so
Fixes: #26097

PR-URL: #26135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.