Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move req_wrap_queue to base class of ReqWrap #26148

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@addaleax
Copy link
Member

commented Feb 16, 2019

Introduce a second base class for ReqWrap that does not
depend on a template parameter and move the req_wrap_queue_
field to it.

This addresses undefined behaviour that occurs when casting
to ReqWrap<uv_req_t> in the ReqWrap constructor.

Refs: #26131

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: move req_wrap_queue to base class of ReqWrap
Introduce a second base class for `ReqWrap` that does not
depend on a template parameter and move the `req_wrap_queue_`
field to it.

This addresses undefined behaviour that occurs when casting
to `ReqWrap<uv_req_t>` in the `ReqWrap` constructor.

Refs: #26131
@danbev

danbev approved these changes Feb 18, 2019

@danbev

This comment was marked as outdated.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Re-run of failing node-test-commit-freebsd

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

Landed in 49a2e40

@addaleax addaleax closed this Feb 20, 2019

@addaleax addaleax deleted the addaleax:req-wrap-queue branch Feb 20, 2019

addaleax added a commit that referenced this pull request Feb 20, 2019

src: move req_wrap_queue to base class of ReqWrap
Introduce a second base class for `ReqWrap` that does not
depend on a template parameter and move the `req_wrap_queue_`
field to it.

This addresses undefined behaviour that occurs when casting
to `ReqWrap<uv_req_t>` in the `ReqWrap` constructor.

Refs: #26131

PR-URL: #26148
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Feb 21, 2019

src: move req_wrap_queue to base class of ReqWrap
Introduce a second base class for `ReqWrap` that does not
depend on a template parameter and move the `req_wrap_queue_`
field to it.

This addresses undefined behaviour that occurs when casting
to `ReqWrap<uv_req_t>` in the `ReqWrap` constructor.

Refs: #26131

PR-URL: #26148
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

src: move req_wrap_queue to base class of ReqWrap
Introduce a second base class for `ReqWrap` that does not
depend on a template parameter and move the `req_wrap_queue_`
field to it.

This addresses undefined behaviour that occurs when casting
to `ReqWrap<uv_req_t>` in the `ReqWrap` constructor.

Refs: #26131

PR-URL: #26148
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.