Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation for the defaultPort option #26152

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@lpinca
Copy link
Member

commented Feb 16, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Show resolved Hide resolved doc/api/http.md Outdated

@lpinca lpinca force-pushed the lpinca:document/default-port branch from 8e5f130 to c39aebf Feb 16, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

@lpinca

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

Yes.

@lpinca

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2019

@lpinca

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2019

Landed in 453ed05...144f876.

@lpinca lpinca closed this Mar 2, 2019

@lpinca lpinca deleted the lpinca:document/default-port branch Mar 2, 2019

lpinca added a commit that referenced this pull request Mar 2, 2019

doc: add documentation for the defaultPort option
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

lpinca added a commit that referenced this pull request Mar 2, 2019

doc: sort http.request() options alphabetically
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax added a commit that referenced this pull request Mar 2, 2019

doc: add documentation for the defaultPort option
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax added a commit that referenced this pull request Mar 2, 2019

doc: sort http.request() options alphabetically
PR-URL: #26152
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@BridgeAR BridgeAR referenced this pull request Mar 4, 2019

Merged

v11.11.0 proposal #26322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.