Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: support name in validateTimerDuration() #26215

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
7 participants
@cjihrig
Copy link
Contributor

commented Feb 20, 2019

As requested in #26214 (review)

Allow passing a name to validateTimerDuration() so that error messages can reflect the name of the thing being validated.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Feb 20, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

timers: support name in validateTimerDuration()
Allow passing a name to validateTimerDuration() so that error
messages can reflect the name of the thing being validated.

PR-URL: #26215
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:val-timer-dur branch from c7ef19d to a1d05e4 Feb 22, 2019

@cjihrig cjihrig merged commit a1d05e4 into nodejs:master Feb 22, 2019

0 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Canceled
Details

@cjihrig cjihrig deleted the cjihrig:val-timer-dur branch Feb 22, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR.

I assume it doesn’t really need to get backported because it’s preparation for a semver-major PR. Feel free to do so, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.