Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove redundant cast in method AfterStringPath #26218

Closed

Conversation

Projects
None yet
5 participants
@gengjiawen
Copy link
Member

commented Feb 20, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@BridgeAR

This comment has been minimized.

@gengjiawen gengjiawen referenced this pull request Feb 28, 2019

Closed

src: remove unused macro in node_http2.h #26204

1 of 2 tasks complete
@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Landed in 10de8d9

@addaleax addaleax closed this Mar 1, 2019

addaleax added a commit that referenced this pull request Mar 1, 2019

src: remove redundant cast in method AfterStringPath
PR-URL: #26218
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Mar 1, 2019

src: remove redundant cast in method AfterStringPath
PR-URL: #26218
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request Mar 4, 2019

Merged

v11.11.0 proposal #26322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.