Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix deprecation "End-of-Life" capitalization #26251

Closed

Conversation

@tniessen
Copy link
Member

commented Feb 21, 2019

There are 78 occurrences of End-of-Life and two occurrences of End-Of-Life.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott

Trott approved these changes Feb 21, 2019

Copy link
Member

left a comment

LGTM. Might be good to add End-Of-Life to https://github.com/Trott/remark-preset-lint-node/blob/594048a86e09993ead132df1c499fee05a239bce/index.js#L49-L55 to keep it from creeping back in.

@cjihrig
Copy link
Contributor

left a comment

LGTM, and agree with @Trott's idea.

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

LGTM, and agree with @Trott's idea.

Once this lands, I'm happy to do it, but a PR is of course welcome!

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

I thought it would make the most sense as part of this PR, but yea, it can be separate too.

richardlau added a commit to richardlau/remark-preset-lint-node that referenced this pull request Feb 22, 2019

@richardlau

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

LGTM. Might be good to add End-Of-Life to https://github.com/Trott/remark-preset-lint-node/blob/594048a86e09993ead132df1c499fee05a239bce/index.js#L49-L55 to keep it from creeping back in.

Since this was easy enough to do in GitHub's web UI editor: nodejs/remark-preset-lint-node#12

BridgeAR added a commit to nodejs/remark-preset-lint-node that referenced this pull request Feb 22, 2019

@lpinca

lpinca approved these changes Feb 23, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Landed in 7e0ddf6

@Trott Trott closed this Feb 23, 2019

Trott added a commit to Trott/io.js that referenced this pull request Feb 23, 2019

doc: fix deprecation "End-of-Life" capitalization
PR-URL: nodejs#26251
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request Feb 23, 2019

tools: update markdown linter
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a
prohibited string, favoring `End-of-Life` for consistency.

Refs: nodejs#26251

@Trott Trott referenced this pull request Feb 23, 2019

Closed

tools: update markdown linter #26281

2 of 2 tasks complete

Trott added a commit to Trott/io.js that referenced this pull request Feb 26, 2019

tools: update markdown linter
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a
prohibited string, favoring `End-of-Life` for consistency.

Refs: nodejs#26251

PR-URL: nodejs#26281
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request Mar 1, 2019

tools: update markdown linter
Update remark-preset-lint-node to 1.4.0. This adds `End-Of-Life` as a
prohibited string, favoring `End-of-Life` for consistency.

Refs: #26251

PR-URL: #26281
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@targos targos added this to Don't land (ever) in v11.x Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.