Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify native immediate by using v8::Global #26254

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Feb 21, 2019

Unlike node::Persistent, v8::Global has move semantics and
can be used directly in STL containers.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: simplify native immediate by using v8::Global
Unlike `node::Persistent`, `v8::Global` has move semantics and
can be used directly in STL containers.
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

src/env-inl.h Outdated Show resolved Hide resolved
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

@jasnell
jasnell approved these changes Mar 1, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

Landed in d64e4de

@addaleax addaleax closed this Mar 1, 2019

@addaleax addaleax deleted the addaleax:env-setimmediate-v8global branch Mar 1, 2019

addaleax added a commit that referenced this pull request Mar 1, 2019
src: simplify native immediate by using v8::Global
Unlike `node::Persistent`, `v8::Global` has move semantics and
can be used directly in STL containers.

PR-URL: #26254
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Mar 2, 2019
src: simplify native immediate by using v8::Global
Unlike `node::Persistent`, `v8::Global` has move semantics and
can be used directly in STL containers.

PR-URL: #26254
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Mar 4, 2019
BethGriggs added a commit that referenced this pull request Apr 16, 2019
src: simplify native immediate by using v8::Global
Unlike `node::Persistent`, `v8::Global` has move semantics and
can be used directly in STL containers.

PR-URL: #26254
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.