Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: provide process.execArgv #26267

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
6 participants
@addaleax
Copy link
Member

commented Feb 22, 2019

Provide process.execArgv. If an execArgv option is passed to the
Worker constructor, that option is used as its value; if not,
the parent’s process.execArgv is inherited (since that also goes
for the actual options in that case).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Feb 22, 2019

@addaleax sadly an error occured when I tried to trigger a build :(

@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

do docs need to be updated for the execArgv option on the Worker constructor?

@addaleax addaleax force-pushed the addaleax:worker-exec-argv branch from 0381d5b to 1da935e Feb 28, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

@jasnell Yup, added a note for that in 1da935e.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

Show resolved Hide resolved doc/api/worker_threads.md Outdated
@jasnell

jasnell approved these changes Mar 1, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

addaleax added some commits Feb 22, 2019

worker: provide process.execArgv
Provide `process.execArgv`. If an `execArgv` option is passed to the
`Worker` constructor, that option is used as its value; if not,
the parent’s `process.execArgv` is inherited (since that also goes
for the actual options in that case).

@addaleax addaleax force-pushed the addaleax:worker-exec-argv branch from a8514d1 to 7cfad4c Mar 1, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2019

Landed in f65b4af

@addaleax addaleax closed this Mar 2, 2019

@addaleax addaleax deleted the addaleax:worker-exec-argv branch Mar 2, 2019

addaleax added a commit that referenced this pull request Mar 2, 2019

worker: provide process.execArgv
Provide `process.execArgv`. If an `execArgv` option is passed to the
`Worker` constructor, that option is used as its value; if not,
the parent’s `process.execArgv` is inherited (since that also goes
for the actual options in that case).

PR-URL: #26267
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Mar 2, 2019

worker: provide process.execArgv
Provide `process.execArgv`. If an `execArgv` option is passed to the
`Worker` constructor, that option is used as its value; if not,
the parent’s `process.execArgv` is inherited (since that also goes
for the actual options in that case).

PR-URL: #26267
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request Mar 4, 2019

Merged

v11.11.0 proposal #26322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.