Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: refactor deprecated method in core.js #26275

Closed

Conversation

@gengjiawen
Copy link
Member

commented Feb 23, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Feb 23, 2019
@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

@lpinca Can you trigger Jenkins ci for this pr and #26284 ? Thanks.

@lpinca

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Subsystem should be http2:

@gengjiawen gengjiawen changed the title lib: refactor deprecated method in core.js http2: refactor deprecated method in core.js Mar 3, 2019

@gengjiawen gengjiawen force-pushed the gengjiawen:rewrite_deprecated_in_core.js branch from aea8d8a to 2760858 Mar 3, 2019

@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

@lpinca Fixed.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
http2: refactor deprecated method in core.js
PR-URL: nodejs#26275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Landed in 905988a 🎉

@BridgeAR BridgeAR closed this Mar 5, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
http2: refactor deprecated method in core.js
PR-URL: nodejs#26275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
http2: refactor deprecated method in core.js
PR-URL: #26275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.