Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage in perf_hooks #26290

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@juanarbol
Copy link
Contributor

commented Feb 24, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@targos

targos approved these changes Feb 24, 2019

@lpinca

lpinca approved these changes Feb 24, 2019

@addaleax

This comment has been minimized.

@antsmartian

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 4, 2019

test: improve test coverage in perf_hooks
PR-URL: nodejs#26290
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Landed in 3826d69 🎉

I fixed the linter issue while landing (the linter complained due to a recent change about the comment).

@BridgeAR BridgeAR closed this Mar 4, 2019

BridgeAR added a commit that referenced this pull request Mar 4, 2019

test: improve test coverage in perf_hooks
PR-URL: #26290
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@juanarbol juanarbol deleted the juanarbol:http2-test-cov branch Mar 4, 2019

@juanarbol

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

@BridgeAR Thank you!!! 🎉

@juanarbol juanarbol restored the juanarbol:http2-test-cov branch Mar 4, 2019

BridgeAR added a commit that referenced this pull request Mar 4, 2019

test: improve test coverage in perf_hooks
PR-URL: #26290
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@BridgeAR BridgeAR referenced this pull request Mar 4, 2019

Merged

v11.11.0 proposal #26322

BridgeAR added a commit that referenced this pull request Mar 5, 2019

test: improve test coverage in perf_hooks
PR-URL: #26290
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs added a commit that referenced this pull request Apr 16, 2019

test: improve test coverage in perf_hooks
PR-URL: #26290
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@BethGriggs BethGriggs referenced this pull request May 1, 2019

Merged

v10.16.0 proposal #27514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.