Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove dead inspector code #26295

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Feb 24, 2019

This was overlooked in c583245.

Refs: #26137

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: remove dead inspector code
This was overlooked in c583245.

Refs: #26137
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Feb 24, 2019

@addaleax sadly an error occured when I tried to trigger a build :(

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

Landed in b0b370c

@addaleax addaleax closed this Mar 1, 2019

@addaleax addaleax deleted the addaleax:inspector-dead-code branch Mar 1, 2019

addaleax added a commit that referenced this pull request Mar 1, 2019
src: remove dead inspector code
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 1, 2019
src: remove dead inspector code
This was overlooked in c583245.

Refs: #26137

PR-URL: #26295
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR BridgeAR referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.