Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.11.0 proposal #26322

Merged
merged 213 commits into from Mar 6, 2019

Conversation

Projects
@BridgeAR
Copy link
Member

BridgeAR commented Feb 26, 2019

Notable Changes

  • n-api:
    • Implement date object (Jarrod Connolly) #25917
  • util:
    • Add compact depth mode for util.inspect() (Ruben Bridgewater) #26269
  • worker:
    • Improve integration with native addons (Anna Henningsen) #26175
    • MessagePort.prototype.onmessage takes arguments closer to the Web specification now (Anna Henningsen) #26082

Commits

  • [d66cb4a116] - benchmark,doc,lib,test: capitalize comments (Ruben Bridgewater) #26223
  • [f4955fde60] - benchmark,test: refactoring (Refael Ackermann) #26119
  • [5e4aa28e1c] - buffer: avoid materializing ArrayBuffer for creation (Anna Henningsen) #26301
  • [05e6ec0143] - build: make 'floating patch' message informational (Ben Noordhuis) #26349
  • [e2baa6836b] - build: remove v8_typed_array_max_size_in_heap option (Anna Henningsen) #26301
  • [fa8110a60e] - build: silence cpp lint by default (Ruben Bridgewater) #26252
  • [dbbcedae6d] - build: tidy up comments in create\_expfile.sh (Richard Lau) #26220
  • [f408d78914] - build: fixed clang's warning when building openssl (Thang Tran) #25954
  • [a3f7471d35] - build,test: guard eslint with crypto check (Daniel Bevenius) #26182
  • [a70bafb3cc] - console: prevent constructing console methods (Thomas) #26096
  • [1333dccede] - crypto: fix unencrypted DER PKCS8 parsing (Tobias Nießen) #26236
  • [70e463c294] - crypto: fix error condition in Verify::VerifyFinal (Tobias Nießen) #26238
  • [108c698f44] - crypto: make ConvertKey clear openssl error stack (Ben Noordhuis) #26153
  • [c8d30a7313] - deps: update acorn to 6.1.0 (gengjiawen) #26102
  • [7f08e0238a] - deps: V8: cherry-pick d3308d0 (Anna Henningsen) #26207
  • [206e4b043b] - deps: V8: backport 74571c8 (Ruben Bridgewater) #25941
  • [f0a81664c7] - deps: backport ICU fix for ARM64 Windows (Jon Kunkee) #26090
  • [ea26ac0f2b] - dns: refactor QueryWrap lifetime management (Anna Henningsen) #26253
  • [846cba056e] - doc: edit deprecation identifier info in Collaborator Guide (Rich Trott) #26372
  • [3f4b27d681] - doc: maxReservedRemoteStreams value constraints (Sebastiaan Deckers) #26309
  • [bc5771ec91] - doc: correct typos in various docs (Beni von Cheni) #26312
  • [3560c3abeb] - doc: sort http.request() options alphabetically (Luigi Pinca) #26152
  • [86982558ad] - doc: add documentation for the defaultPort option (Luigi Pinca) #26152
  • [7bf6309f0b] - doc: napi_get_value_bigint_words argument order (Michael Wei) #26300
  • [40a5a93b41] - doc: add example for setting Vary: Accept-Encoding header in zlib.md (Mukul Khanna) #26308
  • [85840681a4] - doc: revise deprecation semverness info in Collaborator Guide (Rich Trott) #26232
  • [ff57a1c321] - doc: clarify http.ClientRequest path description (Minwoo Jung) #26259
  • [5e44768e9f] - doc: revise deprecation level explanations in Collaborator Guide (Rich Trott) #26197
  • [823f0ce952] - doc: revise Style Guide (Rich Trott) #26176
  • [8fac54a22f] - doc: fix code lang in repl.md (gengjiawen) #26075
  • [e5dae20ed6] - doc: remove deprecation definition in Collaborator Guide (Rich Trott) #26157
  • [e108c32865] - doc: eliminate use of "note that" from child_process.md (Rich Trott) #26141
  • [e506f6a2d6] - doc: remove unnecessary italics from child_process.md (Rich Trott) #26141
  • [b48a04bc32] - doc: remove unnecessary bold text from child_process.md (Rich Trott) #26141
  • [789b818ad1] - doc: remove unnecessary bold italics from child_process.md (Rich Trott) #26141
  • [4d1c87ed6b] - doc: remove all-caps shouting from child_process.md (Rich Trott) #26141
  • [c810ced543] - doc: wrap child_process.md at 80 characters (Rich Trott) #26141
  • [a18b847d18] - doc: improve worker_threads documentation (Anna Henningsen) #26110
  • [a9c44372e1] - doc: consolidate N-API material in Collaborator Guide (Rich Trott) #26094
  • [82bc68b08e] - doc: fix notable changes in v11 changelog (Michaël Zasso)
  • [3971510b66] - doc: fix changelog entry (Colin Ihrig) #26114
  • [2ff1644b34] - doc: fix notable changes list format for 11.9.0 & 11.10.0 (Kai) #26129
  • [8814d03d4d] - doc,lib,test: rename node-report to report (cjihrig) #26371
  • [0034820f67] - errors: add ERR_INSPECTOR_COMMAND error (cjihrig) #26255
  • [030b744941] - esm: process proxy Symbol.toString fix (Guy Bedford) #25963
  • [14cf22f860] - fs, src, lib: fix blksize & blocks on Windows (Richard Lau) #26056
  • [2595fbc8b1] - http2: improve compatibility with http/1 (Sagi Tsofan) #23908
  • [8a551b9d3b] - http2: shrink memory to match read data (Anna Henningsen) #26201
  • [3bc012373a] - inspector: print all listening addresses (Ben Noordhuis) #26008
  • [b0c310dcf0] - inspector: return Error objects on error (cjihrig) #26255
  • [be671c3bf5] - inspector: forward errors from InspectorConsoleCall (Anna Henningsen) #26113
  • [0c4353a444] - inspector: make sure timer handles are cleaned up (Anna Henningsen) #26088
  • [bf61050e91] - lib: converted element to lowercase in tty.js (Abhishek Agarwal) #26121
  • [733beb70ae] - lib: convert legacy process.binding to internalBinding (ZYSzys) #26095
  • [b25694d7ad] - meta: update note about building on smartOS 16 (Refael Ackermann) #25684
  • [6d014a6c3d] - meta: remove the useless GitHub Account (MaleDong) #26146
  • [143b844db2] - meta: moving jasnell temporarily to TSC emeritus (jasnell) #26106
  • [d94f4c23fe] - module: fix stat cache (Ruben Bridgewater) #26266
  • [2a66cd34fa] - module: simpler shebang function (Ruben Bridgewater) #26266
  • [54896a6961] - module: revert module._compile to original state if module is patched (Ujjwal Sharma) #21573
  • [b338edbb0a] - module: use compileFunction over Module.wrap (Ujjwal Sharma) #21573
  • [e72cb94df6] - (SEMVER-MINOR) n-api: implement date object (Jarrod Connolly) #25917
  • [2335bcd6e6] - n-api: turn NAPI_CALL_INTO_MODULE into a function (Anna Henningsen) #26128
  • [1ce5e63987] - n-api: do not call into JS when that is not allowed (Anna Henningsen) #26127
  • [5b8ac58ed8] - path: refactor code for clarity (Ruben Bridgewater) #25278
  • [348f1fbcb3] - path: refactor for less indentation (Ruben Bridgewater) #25278
  • [e00c8cd54a] - path: simplify code and remove obsolete checks (Ruben Bridgewater) #25278
  • [55d6b4961a] - path: refactor logic for to reduce code branches (Ruben Bridgewater) #25278
  • [6c7cd9ee5a] - path: minor refactoring (Ruben Bridgewater) #25278
  • [cccc44b854] - path: refactor more path code for simplicity (Ruben Bridgewater) #25278
  • [6c44e68f63] - path: more small refactorings (Ruben Bridgewater) #25278
  • [b0cde2c4cf] - path: minor refactoring (Ruben Bridgewater) #25278
  • [d91520724c] - process: use common operations to define browser globals (Joyee Cheung) #26230
  • [b1e739d881] - process: move initialization of node-report into pre_execution.js (Joyee Cheung) #26227
  • [57179a0aab] - process: setup signal handler in prepareMainThreadExecution (Joyee Cheung) #26227
  • [966546ceaa] - process: simplify the setup of async hooks trace events (Joyee Cheung) #26062
  • [cd10e25bd6] - process: move test-process-uptime to parallel (Joyee Cheung) #26206
  • [fde40116c4] - process: fix calculation in process.uptime() (Joyee Cheung) #26206
  • [230e98b54a] - process: start coverage collection before bootstrap (Joyee Cheung) #26006
  • [b5fe27ccc9] - process: delay setup of global exception handlers (Joyee Cheung) #26061
  • [0d660d9646] - readline: improve Unicode handling (Avi ד) #25723
  • [4c254d6294] - repl: use object writer for thrown errors (Anna Henningsen) #26361
  • [2a74a1ed60] - repl: hide editor mode if not used in a terminal (Ruben Bridgewater) #26240
  • [2fa8170e51] - repl: add new line on ctrl+d (Ruben Bridgewater) #26240
  • [f636f15315] - repl: add more information (Ruben Bridgewater) #26240
  • [2908e6313b] - report: rename location to trigger (cjihrig) #26386
  • [0579f4283f] - report: use triggerReport() to handle signals (cjihrig) #26386
  • [b2c77ec081] - report: use triggerReport() to handle exceptions (cjihrig) #26386
  • [b62e2289d9] - report: add fallback for uv_getnameinfo() failures (Richard Lau) #26140
  • [2fe9886f6f] - report: fix build warning in node_report.cc (Richard Lau) #26265
  • [ba5f31ac45] - report: use ru_stime for system CPU calculation (cjihrig) #26286
  • [d2d94537b2] - report: simplify heap space iteration (cjihrig) #26285
  • [6d2a14d385] - report: refactor argument validation (cjihrig) #26276
  • [8e2cc5e440] - report: refactor triggerReport() (cjihrig) #26268
  • [8a40468635] - report: remove verbose setting (cjihrig) #26195
  • [0e89d7add6] - report: simplify OnFatalError() handling (cjihrig) #26191
  • [633c1eac29] - report: simplify TriggerNodeReport() (cjihrig) #26174
  • [fc9ba36fb2] - src: fix typo in callback.cc (gengjiawen) #26337
  • [63942de82c] - src: extra-semi warning in node_platform.h (Jeremy Apthorp) #26330
  • [cb62c24e1b] - src: reduce to simple const char\* in OptionsParser (ZYSzys) #26297
  • [3093617c0e] - src: remove unused variable (cjihrig) #26386
  • [b216f44513] - src: remove unnecessary function declaration (cjihrig) #26386
  • [cb2cbf2eca] - src: remove already elevated Isolate namespce (Juan José Arboleda) #26294
  • [2438a4350d] - src: remove unused macro in env.cc (gengjiawen) #26273
  • [4df82f0f1b] - src: remove unused macro in node_http2.h (gengjiawen) #26204
  • [af2a6935ab] - src: remove redundant cast in PipeWrap::Fchmod (gengjiawen) #26242
  • [06d592c551] - src: simplify native immediate by using v8::Global (Anna Henningsen) #26254
  • [9b4eec0aad] - src: allow not materializing ArrayBuffers from C++ (Anna Henningsen) #26301
  • [30f0a3b4bd] - src: remove dead inspector code (Anna Henningsen) #26295
  • [c37b6796df] - src: remove unused Converter object (Anna Henningsen) #26243
  • [6f9ab5e15b] - src: remove redundant cast in method AfterStringPath (gengjiawen) #26218
  • [33d6a3fcb7] - src: clean up StreamPipe in destructor (Anna Henningsen) #26256
  • [75ae77d99f] - src: do not access Environment-owned handles after cleanup (Anna Henningsen) #26256
  • [d6759db15b] - src: remove cast for unsupported openssl (Sam Roberts) #26305
  • [1abe1d1c06] - src: track memory retainer fields (Gireesh Punathil) #26161
  • [3e0978d7a3] - src: clean unused macro in inspector_socket.cc (gengjiawen) #26158
  • [4001b24f79] - src: remove unimplemented method in class SSLWrap (gengjiawen) #26203
  • [8b515b24af] - src: apply clang-tidy rule modernize-deprecated-headers (gengjiawen) #26159
  • [3c11b4eec2] - src: allocate Buffer memory using ArrayBuffer allocator (Anna Henningsen) #26207
  • [282607644b] - src: add allocation utils to env (Anna Henningsen) #26207
  • [238fa5704b] - src: add debugging array allocator (Anna Henningsen) #26207
  • [437bb25d92] - src: make IsolateData store ArrayBufferAllocator (Anna Henningsen) #26207
  • [68accb5b04] - src: use smart pointer in UDPWrap::OnSend (Daniel Bevenius) #26233
  • [3abdcfc813] - src: remove unimplemented method in class StreamPipe (gengjiawen) #26202
  • [7e26ca6750] - src: simplify AliasedBuffer lifetime management (Anna Henningsen) #26196
  • [831aa9acb6] - src: make node::SignalWrap::OnSignal into lambda (Gireesh Punathil) #26184
  • [619b5e7c2e] - src: simplify loop arithmetic in GetCPUInfo (Gireesh Punathil) #26183
  • [ddd71f4a92] - src: move function from header to source file (Ben Noordhuis) #26173
  • [5cc2574fac] - src: move async hooks trace events setup to pre_execution.js (Joyee Cheung) #26062
  • [8881c0baaa] - src: simplify InspectorConsoleCall (Anna Henningsen) #26168
  • [c6d5af53be] - src: move req_wrap_queue to base class of ReqWrap (Anna Henningsen) #26148
  • [a39cd45ce8] - src: remove process.binding('config').fipsForced (Joyee Cheung) #26178
  • [bd40a127f9] - src: only call .ReThrow() if not terminating (Anna Henningsen) #26130
  • [6b7d8369e3] - src: add missing includes for vtune build (Uttam Pawar) #26136
  • [25ddbc9a36] - src: apply clang-tidy rule performance-unnecessary-value-param (gengjiawen) #26042
  • [82df851bb5] - src: unify uptime base used across the code base (Joyee Cheung) #26016
  • [778db675c1] - src: remove invalid casts in options parser (Anna Henningsen) #26139
  • [4ca07898d7] - src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node (Joyee Cheung) #26034
  • [e6949b4241] - src: apply clang-tidy rule modernize-use-override (gengjiawen) #26103
  • [d550de4fe1] - src: remove inspector main_thread_request_ field (Anna Henningsen) #26137
  • [ee71952a25] - src: check HasCaught() in JSStream calls (Anna Henningsen) #26124
  • [f44f33569d] - src: extract common sockaddr creation code (Daniel Bevenius) #26070
  • [cbd3cf083a] - src: add debug CHECKs against empty handles (Anna Henningsen) #26125
  • [0408966a9d] - src: remove unused macro in node_file.cc (gengjiawen) #26073
  • [497d9d8ab2] - src: use same parameter name in node_report.cc (gengjiawen) #26046
  • [e314681420] - src: use more stable cast where possible (Gireesh Punathil) #26052
  • [7612574e42] - stream: make _read() be called indefinitely if the user wants so (Matteo Collina) #26135
  • [50e42c9d64] - test: improve test coverage in perf_hooks (Juan José Arboleda) #26290
  • [a41138b0cf] - test: remove duplicated buffer negative allocation test (ZYSzys) #26160
  • [93d7fa3df3] - test: only inspect on failure (Ruben Bridgewater) #26360
  • [91b61452c3] - test: always activate colors if necessary (Ruben Bridgewater) #26264
  • [11bd5e07cb] - test: rename node-report suite to report (cjihrig) #26371
  • [7ccffcbcb6] - test: improve validation of report output (cjihrig) #26289
  • [4561cf351f] - test: verify heap buffer allocations occur (Anna Henningsen) #26301
  • [0c8e9ee62e] - test: fix for activities in tick objects prune function (Alexander Sattelmaier) #26163
  • [69154e405c] - test: refactor tick objects prune function (Alexander Sattelmaier) #26163
  • [d8f5f55b78] - test: eliminate port collision (Gireesh Punathil) #26298
  • [88256d7ba2] - test: simplify node-report/test-exception.js (cjihrig) #26277
  • [e8995d1b80] - test: increase getReport() coverage (cjihrig) #26276
  • [33fe892ec6] - test: increase triggerReport() coverage (cjihrig) #26268
  • [a382b52fd8] - test: consolidate triggerReport() tests (cjihrig) #26268
  • [6f9a764b52] - test: remove node-report/test-api.js (cjihrig) #26219
  • [bc114152d0] - test: simplify test-api-nohooks.js (cjihrig) #26217
  • [ca18525896] - test: improve performance of test-crypto-timing-safe-equal-benchmarks (Rich Trott) #26237
  • [28758b8d69] - test: add test for dynamically enabling node.async_hooks tracing (Joyee Cheung) #26062
  • [dcbd907142] - test: add test for node.async_hooks tracing in workers (Joyee Cheung) #26062
  • [007b2fa198] - test: increase run time in test-worker-prof (Anna Henningsen) #26172
  • [a1fcde035e] - test: simplify test-api-getreport.js (cjihrig) #26169
  • [818b280a39] - test: remove unnecessary default tmpdir value in test (Rich Trott) #26177
  • [59ca9e9ccf] - test: consolidate assertions in ipv6only test (Rich Trott) #26149
  • [38a87d5521] - test: increase coverage of node_report_module.cc (Richard Lau) #26116
  • [76c2f4f46b] - test: simplify test-worker-syntax-error (Rich Trott) #26144
  • [441b5453a0] - test: fix flaky test-worker-ref-onexit (Anna Henningsen) #26170
  • [d3525d7505] - test: add --test-root option to test.py (Yang Guo) #26093
  • [a920721175] - test: silence compiler warning in openssl-binding (Daniel Bevenius) #26067
  • [2d0242a69b] - test: increase coverage for assertion_error.js (Rich Trott) #26065
  • [dd60cd60b3] - test: add arg to narrow http benchmark test (Refael Ackermann) #26101
  • [fbf6dd558a] - test,inspector: add heap allocation tracker test (Anna Henningsen) #26089
  • [db94ab778f] - test,worker: posting undefined/null message to message port (legendecas) #26123
  • [d1e3724b5d] - test,worker: add more tests for worker.ref()/.unref() (Anna Henningsen) #26083
  • [96a5765491] - tools: update extend to 3.0.2 (Rich Trott) #26392
  • [6e9a7e1048] - tools: remove unneeded .gitignore entries (Rich Trott) #26370
  • [123fad6e1c] - tools: update babel-eslint to 10.0.1 (Rich Trott) #26347
  • [347dd99251] - tools: update eslint-plugin-markdown to 1.0.0 (Rich Trott) #26345
  • [adcbcf5bd6] - tools: use latest rather than next for markdown linting plugin (Rich Trott) #26345
  • [0080350f1a] - tools: update markdown linter (Rich Trott) #26281
  • [dff0149d57] - tools: update ESLint to 5.14.1 (cjihrig) #26190
  • [28d607444d] - tools: update ESLint to 5.14.0 (cjihrig) #26142
  • [1766b8c341] - trace_events: fix trace events JS API writing (Kelvin Jin) #24945
  • [34c685b406] - tracing: use ‘real’ atomics (Anna Henningsen) #26156
  • [b6355ef602] - tty: improve color detection (Ruben Bridgewater) #26264
  • [001785520a] - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) #26226
  • [6828fbb2ef] - (SEMVER-MINOR) util: group array elements together (Ruben Bridgewater) #26269
  • [4500ed85e9] - (SEMVER-MINOR) util: add compact depth mode (Ruben Bridgewater) #26269
  • [34905fc2b9] - util: mark iterator entries as such (Ruben Bridgewater) #26222
  • [4bf58ac13d] - util: update set iterator entries inspection (Ruben Bridgewater) #25941
  • [7d66d47dba] - vm: do not overwrite error when creating context (Anna Henningsen) #26112
  • [8cf4170c94] - worker: provide process.execArgv (Anna Henningsen) #26267
  • [6fdc502a32] - worker: make MessagePort uv\_async\_t inline field (Anna Henningsen) #26271
  • [51f01aa25b] - worker: remove MessagePort::AddToIncomingQueue (Anna Henningsen) #26271
  • [74d11e7d0e] - worker: refactor thread life cycle management (Gireesh Punathil) #26099
  • [20dc172011] - worker: copy transferList ArrayBuffers on unknown allocator (Anna Henningsen) #26207
  • [7e7023373a] - worker: serialize errors if stack getter throws (Rich Trott) #26145
  • [a9a2c5869c] - (SEMVER-MINOR) worker: improve integration with native addons (Anna Henningsen) #26175
  • [dab3d71243] - worker: ignore --abort-on-uncaught-exception for terminate() (Anna Henningsen) #26111
  • [dab64bb0e8] - worker: spin uv_run twice before closing loop (Anna Henningsen) #26138
  • [24debc9d5c] - worker: do not add removed methods to MessagePort (Anna Henningsen) #26109
  • [8045e40917] - worker: remove duplicate call (Gireesh Punathil) #26104
  • [69298713af] - worker: switch to internal assert module (Rich Trott) #26091
  • [77a944cdee] - worker: use fake MessageEvent for port.onmessage (Anna Henningsen) #26082
  • [851a691678] - zlib: report premature ends earlier (Anna Henningsen) #26363
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Feb 26, 2019

@BridgeAR sadly an error occured when I tried to trigger a build :(

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Feb 26, 2019

@nodejs/releasers it was originally planned to release a new current version today. However, the CI is still locked due to the upcoming security release. Should someone else trigger the CI and release this before the security release or shall we wait until that's out of the way?

@BridgeAR BridgeAR force-pushed the v11.11.0-proposal branch from 0e7044b to 4df8b8a Feb 26, 2019

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Feb 26, 2019

I'd suggest delaying to avoid potential confusion. v10.15.2 was also due today but has been delayed.

kjin and others added some commits Dec 10, 2018

trace_events: fix trace events JS API writing
The Trace Events JS API isn't functional if none of
--trace-events-enabled or --trace-event-categories is passed as a CLI
argument. This commit fixes that.

In addition, we currently don't test the trace_events JS API in the
casewhere no CLI args are provided. This commit adds that test.

Fixes #24944

PR-URL: #24945
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
build: fixed clang's warning when building openssl
clang doesn't seem to support 'Wno-old-style-declaration', this
is a work-around.

Fixes: #25550
Refs: nodejs/node-v0.x-archive#4186

PR-URL: #25954
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
src: use more stable cast where possible
PR-URL: #26052
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
fs, src, lib: fix `blksize` & `blocks` on Windows
libuv returns values for `blksize` and `blocks` on stat calls so
do not coerce them into `undefined` on Windows.

PR-URL: #26056
Fixes: #25913
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: increase coverage for assertion_error.js
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

PR-URL: #26065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
test: add arg to narrow http benchmark test
PR-URL: #26101
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
meta: moving jasnell temporarily to TSC emeritus
Moving myself temporarily to TSC emertus status. Expecting to
take a two month hiatus from TSC duties while I focus on some
NearForm internal business.

PR-URL: #26106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
process: delay setup of global exception handlers
Since bootstrap/node.js performs the setup synchronously,
the process exception handlers do not have to setup so early in
the bootstrap process - any fatal errors thrown before user code
execution should simply crash the process, and we do not care
about any clean up at that point. We don't care about emitting any
events if the process crash upon bootstrap either.

PR-URL: #26061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gus Caplan <me@gus.host>
src: use same parameter name in node_report.cc
PR-URL: #26046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
test: silence compiler warning in openssl-binding
Currently, this test generated the following compiler warning:
../binding.cc:33:30: warning:
'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations]
  const SSL_METHOD* method = TLSv1_2_server_method();
                             ^
/node/deps/openssl/openssl/include/openssl/ssl.h:1877:1:
note: 'TLSv1_2_server_method' has been explicitly marked deprecated here
DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void))
^
1 warning generated.

This commit adds -Wno-deprecated-declarations to silence this warning
for this test.

PR-URL: #26067
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
src: remove unused macro in node_file.cc
PR-URL: #26073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
worker: use fake MessageEvent for port.onmessage
Instead of passing the payload for Workers directly to `.onmessage`,
perform something more similar to what the browser API provides,
namely create an event object with a `.data` property.

This does not make `MessagePort` implement the `EventTarget` API, nor
does it implement the full `MessageEvent` API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.

(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)

PR-URL: #26082
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
test,worker: add more tests for worker.ref()/.unref()
PR-URL: #26083
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
inspector: make sure timer handles are cleaned up
It is not obvious that timer handles are cleaned up properly
when the current `Environment` exits, nor that the `Environment`
knows to keep track of the closing handles.

This change may not be necessary, because timer handles
close without non-trivial delay (i.e. at the end of the current
event loop term), and JS-based inspector sessions (which are
the only ones we can easily test) are destroyed when cleaning up,
closing the timers as a result. I don’t know what happens
for other kinds of inspector sessions, though.

PR-URL: #26088
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
worker: switch to internal assert module
PR-URL: #26091
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
doc: consolidate N-API material in Collaborator Guide
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: #26094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
worker: remove duplicate call
`Environment::RunCleanup` is invoked twice in a row,
remove one.

PR-URL: #26104
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
worker: do not add removed methods to MessagePort
Do not put the `.stop()` and `.drain()` methods on the
`MessagePort` prototype if we are going to remove them
later on anyway.

PR-URL: #26109
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
vm: do not overwrite error when creating context
An empty `Local<>` already indicates that an exception is pending,
so there is no need to throw an exception. In the case of Workers,
this could override a `.terminate()` call.

PR-URL: #26112
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: fix changelog entry
PR-URL: #26114
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
doc: fix notable changes list format for 11.9.0 & 11.10.0
PR-URL: #26129
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
src: extract common sockaddr creation code
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
test: add --test-root option to test.py
This way we can specify a custom path for the test folder, e.g.
when building addons separately from the source tree.

PR-URL: #26093
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Mar 5, 2019

@BridgeAR Fwiw, the first commit in that PR seemed to be okay. The notable changes LGTM 👍

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 5, 2019

@addaleax AFAIK we always include / exclude whole PRs and not individual commits from a PR.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

@nodejs/releasers @nodejs/build any opinion on the benchmark failures from the V8-CI? Should this block the release? It seems reproducible on each run.

@targos

This comment has been minimized.

Copy link
Member

targos commented Mar 6, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

@targos it does

@targos

This comment has been minimized.

Copy link
Member

targos commented Mar 6, 2019

So I guess it's an infra issue and we can go ahead and ignore it?

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

Seems like there is one legitimate test failure for the --without-ssl builds.

I am looking into it right now.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

It seems a deprecation warning is emitted twice for such builds while requireing 'node-inspect/lib/internal/inspect_client'. https://ci.nodejs.org/job/node-test-commit-linux-containered/11111/nodes=ubuntu1604_sharedlibs_withoutssl_x64/console

I would like to ignore that test for now as it does not seem critical to block the release. Any other opinions? @nodejs/releasers @nodejs/tsc

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

I am not able to reproduce the issue locally by the way.

@bcoe

This comment has been minimized.

Copy link
Member

bcoe commented Mar 6, 2019

@BridgeAR I'd like to advocate that we backport c78788a, this makes coverage work significantly better.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 6, 2019

@bcoe we plan on releasing a new version in a week again and I would rather get this release out as it is as long as nothing is blocking it.

@bcoe

This comment has been minimized.

Copy link
Member

bcoe commented Mar 6, 2019

sounds good @BridgeAR 👍 just want to make sure some of these backports are on our radar. I'm going to also see if we could port any of these patches back to 8.x.

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Mar 6, 2019

It seems a deprecation warning is emitted twice for such builds while requireing 'node-inspect/lib/internal/inspect_client'. https://ci.nodejs.org/job/node-test-commit-linux-containered/11111/nodes=ubuntu1604_sharedlibs_withoutssl_x64/console

I would like to ignore that test for now as it does not seem critical to block the release. Any other opinions? @nodejs/releasers @nodejs/tsc

We have only just enabled the --without-ssl builds in the last week: nodejs/build#1574

The test in question doesn't exist in master (removed in #25138 which is semver-major). I kicked off https://ci.nodejs.org/job/node-test-commit-linux-containered/11117/ against v11.x (i.e. 11.10.1) and the test failed there so it's not a new regression in this proposed release so I'm okay with ignoring this for now but we do need to address it so the builds pass for the next 11.x release.

@BridgeAR BridgeAR merged commit 6d774a7 into v11.x Mar 6, 2019

BridgeAR added a commit to BridgeAR/nodejs.org that referenced this pull request Mar 6, 2019

BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Mar 6, 2019

@BridgeAR BridgeAR deleted the v11.11.0-proposal branch Mar 6, 2019

@targos targos added this to Releases in v11.x Mar 7, 2019

@refack

This comment has been minimized.

Copy link
Member

refack commented Mar 13, 2019

a bit off-topic, but, there's lint in the v11.x-staging branch - https://travis-ci.com/nodejs/node/builds/104258827

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 13, 2019

@refack this has nothing to do with that release. I am working currently working on the staging branch to have a working branch to open a new release proposal but there were lots and lots of conflicts this time and I had to bisect a few times to find the commit that caused issues. So I am still going to force-push all issues out.

@ZauberNerd

This comment has been minimized.

Copy link
Contributor

ZauberNerd commented Mar 26, 2019

@BridgeAR with V11.11.0 something changed in regards to how require handles failed attempts:
With v11.10.1 and below the following worked:

try {
  require('./non-existant');
} catch (e) {}
require('fs').writeFileSync('./non-existant', '{}');
require('./non-existant');

The second require attempt does not throw but instead resolves to the file.
With Node v11.11.0 the second (and all following) require calls throw an error that the module has not been found. I tried looking into deleting the require.cache but it seems like the cache does not have entries for failed require attempts.

I have found the following three commits that touch the module system, which might be causing this behaviour:

I'm currently trying to compile each of these commits to find out which one introduced this behaviour and will open a proper issue once I have found out what actually happens here.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Mar 26, 2019

@ZauberNerd thanks for reporting that. It should indeed resolve and I am pretty sure it's d94f4c2 that broke this.

Please open a separate issue for this though. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.