Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unneeded .gitignore entries #26370

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 1, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@refack
refack approved these changes Mar 1, 2019
@cjihrig
cjihrig approved these changes Mar 1, 2019
icu_config.gypi
.eslintcache

This comment has been minimized.

Copy link
@cjihrig

cjihrig Mar 1, 2019

Contributor

What is the reasoning for removing this one? I wouldn't expect everyone to have this in their own .gitignore.

This comment has been minimized.

Copy link
@refack

refack Mar 1, 2019

Member

IIUC they are all covered by

.*

This comment has been minimized.

Copy link
@richardlau

richardlau Mar 1, 2019

Member

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

This comment has been minimized.

Copy link
@Trott

Trott Mar 1, 2019

Author Member

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@richardlau I've updated the commit message to say:

Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.
icu_config.gypi
.eslintcache

This comment has been minimized.

Copy link
@richardlau

richardlau Mar 1, 2019

Member

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@Trott Trott force-pushed the Trott:eslintcache branch from c45a9da to b9f1338 Mar 1, 2019

tools: remove unneeded .gitignore entries
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.
@jasnell
jasnell approved these changes Mar 1, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2019

@Trott Trott added the author ready label Mar 2, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

Landed in b97cd9b

@Trott Trott closed this Mar 3, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 3, 2019
tools: remove unneeded .gitignore entries
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: nodejs#26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 4, 2019
tools: remove unneeded .gitignore entries
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Mar 4, 2019
BethGriggs added a commit that referenced this pull request Apr 16, 2019
tools: remove unneeded .gitignore entries
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.