Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove unused variable in _http_server.js #26407

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 3, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Mar 3, 2019

@lpinca

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Mar 3, 2019

Subsystem in commit message should be http:

@gengjiawen gengjiawen changed the title lib: remove unused variable in _http_server.js http: remove unused variable in _http_server.js Mar 3, 2019

@gengjiawen gengjiawen force-pushed the gengjiawen:cleanup_http_server branch from 1921896 to 74e4711 Mar 3, 2019

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

gengjiawen commented Mar 3, 2019

@lpinca Fixed :)

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Mar 3, 2019

@jasnell

jasnell approved these changes Mar 4, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 5, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 6, 2019

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Mar 7, 2019

Re-run of failing node-test-commit-arm-fanned (✔️)

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Mar 7, 2019

Landed in 0fa1165.

@danbev danbev closed this Mar 7, 2019

danbev added a commit that referenced this pull request Mar 7, 2019

http: remove unused variable in _http_server.js
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

http: remove unused variable in _http_server.js
PR-URL: nodejs#26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

http: remove unused variable in _http_server.js
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.