Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: simplify GetPublicOrPrivateKeyFromJs #26454

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@tniessen
Copy link
Member

tniessen commented Mar 5, 2019

The last argument is now always set to true due to #26278. This change removes said argument and its only usage in an assertion.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@bnoordhuis
Copy link
Member

bnoordhuis left a comment

LGTM. I felt it should have been an enum in the first place. :-)

@lpinca

lpinca approved these changes Mar 5, 2019

@jasnell

jasnell approved these changes Mar 5, 2019

@BridgeAR

This comment has been minimized.

@shisama

shisama approved these changes Mar 6, 2019

@shisama

This comment has been minimized.

Copy link
Contributor

shisama commented Mar 6, 2019

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Mar 6, 2019

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Mar 7, 2019

Thanks for reviewing, everyone! Landed in 3e4e518.

@tniessen tniessen closed this Mar 7, 2019

tniessen added a commit that referenced this pull request Mar 7, 2019

crypto: simplify GetPublicOrPrivateKeyFromJs
PR-URL: #26454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

crypto: simplify GetPublicOrPrivateKeyFromJs
PR-URL: nodejs#26454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

crypto: simplify GetPublicOrPrivateKeyFromJs
PR-URL: #26454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.