Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite ocsp test to use mustCall, etc. #26460

Closed
wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Member

commented Mar 5, 2019

Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
test/parallel/test-tls-ocsp-callback.js Outdated Show resolved Hide resolved

@sam-github sam-github force-pushed the sam-github:test-ocsp-with-mustcall branch 3 times, most recently from a45e5e9 to acd99cb Mar 5, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@cjihrig
cjihrig approved these changes Mar 6, 2019
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

@sam-github sam-github force-pushed the sam-github:test-ocsp-with-mustcall branch from acd99cb to 1126aa4 Mar 6, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

ci: https://ci.nodejs.org/job/node-test-pull-request/21271/

Changed the commit title, using etc. fools the message linter into thinking the commit description is using sentence punctuation.

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@sam-github I stopped the new CI since the last one passed. Was it intentional to start a new one?

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

@BridgeAR I thought it passed, too, but git node land did not agree:

   ⚠  Commits were pushed since the last review:
...
? This PR is not ready to land, do you want to continue? (Y/n)
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

@sam-github the reason for the complaint is that there is no LG since the last push (due to changing the commit message). It was not about the CI.

@BridgeAR
Copy link
Member

left a comment

Still LG

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 9, 2019
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: nodejs#26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Landed in 7891339 🎉

@BridgeAR BridgeAR closed this Mar 9, 2019

@sam-github sam-github deleted the sam-github:test-ocsp-with-mustcall branch Mar 11, 2019

BridgeAR added a commit that referenced this pull request Mar 13, 2019
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 13, 2019
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
test: rewrite ocsp test to run in parallel
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.