Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: make Symbol.toStringTag writable #26488

Closed
wants to merge 1 commit into from

Conversation

@BridgeAR
Copy link
Member

commented Mar 7, 2019

The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

Refs: #25963 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

We could switch this to use getter/setters so we are able to deprecate setting this property as semver-major.

@BridgeAR BridgeAR requested review from addaleax and guybedford Mar 7, 2019

@SimenB SimenB referenced this pull request Mar 7, 2019

Closed

esm: fixup process Proxy to handle toString correctly #25963

3 of 3 tasks complete
@guybedford

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Actually making it a getter so we can deprecate it as major does sound sensible. Especially given Jest already have a fix here. Shall we do a docs-only deprecation here then?

@targos

targos approved these changes Mar 7, 2019

@hiroppy

hiroppy approved these changes Mar 8, 2019

@hiroppy hiroppy referenced this pull request Mar 8, 2019

Merged

chore(deps): update jest to v24.3.1 #1704

0 of 6 tasks complete
@jasnell

jasnell approved these changes Mar 8, 2019

@BridgeAR

This comment has been minimized.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: nodejs#26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

Landed in 2a7da11 🎉

@BridgeAR BridgeAR closed this Mar 12, 2019

BridgeAR added a commit that referenced this pull request Mar 13, 2019

process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: #26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 13, 2019

2019-03-14, Version 11.12.0 (Current)
Notable Changes

* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* crypto:
  * Add `KeyObject.asymmetricKeySize` (Patrick Gansterer)
    #26387
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

@guybedford are you going to open a PR for the deprecation? I personally have no strong opinion about that.

BridgeAR added a commit that referenced this pull request Mar 14, 2019

process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: #26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

2019-03-14, Version 11.12.0 (Current)
Notable Changes

* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527

BridgeAR added a commit that referenced this pull request Mar 14, 2019

2019-03-14, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527

BridgeAR added a commit that referenced this pull request Mar 14, 2019

2019-03-14, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527
@guybedford

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@BridgeAR I know it seems small, but intrinsics have non-writeable toStringTags because they are supposed to provide a certain level of consistency so I do think it would be more correct to do this. I don't feel particularly strongly about it either, but will aim to get to the PR as it seems better than not.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019

process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: nodejs#26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019

2019-03-14, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    nodejs#25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    nodejs#26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    nodejs#26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) nodejs#26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) nodejs#26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    nodejs#26527

BridgeAR added a commit that referenced this pull request Mar 14, 2019

process: make Symbol.toStringTag writable
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: #26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

2019-03-14, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527

BridgeAR added a commit that referenced this pull request Mar 15, 2019

2019-03-15, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    #25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    #26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    #26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) #26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) #26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    #26527

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 15, 2019

2019-03-15, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    nodejs#25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    nodejs#26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    nodejs#26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) nodejs#26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) nodejs#26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    nodejs#26527

@guybedford guybedford referenced this pull request Mar 17, 2019

Open

process: deprecate toStringTag assignment #26717

4 of 4 tasks complete

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

2019-03-15, Version 11.12.0 (Current)
Notable Changes

* bootstrap:
  * Add experimental `--frozen-intrinsics` flag (Guy Bedford)
    nodejs#25685
* build:
  * Enable v8's siphash for hash seed creation (Rod Vagg)
    nodejs#26367
* deps:
  * Upgrade openssl to 1.1.1b (Sam Roberts)
    nodejs#26327
* process:
  * Make `process[Symbol.toStringTag]` writable again
    (Ruben Bridgewater) nodejs#26488
* repl:
  * Add `util.inspect.replDefaults` to customize the writer
    (Ruben Bridgewater) nodejs#26375
* report:
  * Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
    nodejs#26527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.