Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: add --pending-deprecation to `process.binding()` #26500

Closed
wants to merge 3 commits into
base: master
from

Conversation

@addaleax
Copy link
Member

addaleax commented Mar 7, 2019

Print a deprecation warning for process.binding() when using
--pending-deprecation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
process: add --pending-deprecation to `process.binding()`
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.
@cjihrig

cjihrig approved these changes Mar 7, 2019

Show resolved Hide resolved lib/internal/bootstrap/pre_execution.js Outdated
@Trott

Trott approved these changes Mar 7, 2019

@devsnek

devsnek approved these changes Mar 7, 2019

@jasnell

jasnell approved these changes Mar 7, 2019

@targos

targos approved these changes Mar 8, 2019

@shisama

shisama approved these changes Mar 8, 2019

@BridgeAR

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 8, 2019

@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied).

Show resolved Hide resolved doc/api/deprecations.md
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Mar 8, 2019

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Mar 8, 2019

@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied).

None of the files changed in this PR are exclusive to process though.

@joyeecheung

This comment has been minimized.

Copy link
Member

joyeecheung commented Mar 8, 2019

None of the files changed in this PR are exclusive to process though.

I guess it should be safe to map lib/internal/bootstrap/* changes to process

@ChALkeR

ChALkeR approved these changes Mar 8, 2019

Copy link
Member

ChALkeR left a comment

👍

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Mar 11, 2019

Landed in 148254744134793cd6556c9749658f3872b03d002

@addaleax addaleax closed this Mar 11, 2019

@addaleax addaleax deleted the addaleax:process-binding-pd branch Mar 11, 2019

addaleax added a commit that referenced this pull request Mar 11, 2019

process: add --pending-deprecation to `process.binding()`
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.

PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 13, 2019

process: add --pending-deprecation to `process.binding()`
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.

PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

process: add --pending-deprecation to `process.binding()`
Print a deprecation warning for `process.binding()` when using
`--pending-deprecation`.

PR-URL: #26500
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.