Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump test-bootstrap-modules.js limit #26520

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@joyeecheung
Copy link
Member

commented Mar 8, 2019

Refs: #25594
Fixes: #26528

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21334/
Please thumbs up this reply if you are +1 to fast-track - this unbreaks master.

@cjihrig
cjihrig approved these changes Mar 8, 2019
@devsnek
devsnek approved these changes Mar 8, 2019
Copy link
Member

left a comment

sorry about this

@lpinca
lpinca approved these changes Mar 8, 2019
@refack
refack approved these changes Mar 8, 2019
@tniessen

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Fixes: #26528

test: bump test-bootstrap-modules.js limit
PR-URL: #26520
Fixes: #26528
Refs: #25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack force-pushed the joyeecheung:qmt branch from 34e2ec5 to 4fe66a3 Mar 8, 2019

@refack refack merged commit 4fe66a3 into nodejs:master Mar 8, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
test: bump test-bootstrap-modules.js limit
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
test: bump test-bootstrap-modules.js limit
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
test: bump test-bootstrap-modules.js limit
PR-URL: #26520
Fixes: #26528
Refs: #25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.