Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit Landing Pull Requests #26536

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Mar 8, 2019

Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.
@danbev
danbev approved these changes Mar 9, 2019
@shisama
shisama approved these changes Mar 9, 2019
@targos
targos approved these changes Mar 9, 2019
@cjihrig
cjihrig approved these changes Mar 9, 2019

@vsemozhetbyt vsemozhetbyt added the meta label Mar 9, 2019

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Landed in cc2c07c

@Trott Trott closed this Mar 11, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 11, 2019
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: nodejs#26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 13, 2019
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 13, 2019
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
doc: edit Landing Pull Requests
Edit the Landing Pull Requests section of the Collaborators Guide for
brevity and clarity.

PR-URL: #26536
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.