Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: check for invalid chacha20-poly1305 IVs #26537

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@sam-github
Copy link
Member

sam-github commented Mar 8, 2019

IV lengths of 13, 14, 15, and 16 are invalid, but are not checked by
OpenSSL. IV lengths of 17 or greater are also invalid, but they
were already checked by OpenSSL.

See:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@sam-github sam-github requested a review from tniessen Mar 8, 2019

crypto: check for invalid chacha20-poly1305 IVs
IV lengths of 13, 14, 15, and 16 are invalid, but are not checked by
OpenSSL. IV lengths of 17 or greater are also invalid, but they
were already checked by OpenSSL.

See:
- openssl/openssl@f426625
- https://www.openssl.org/news/secadv/20190306.txt

@sam-github sam-github force-pushed the sam-github:check-for-invalid-chacha20-poly1305-iv-lengths branch from 13223f1 to 481bc07 Mar 8, 2019

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Mar 8, 2019

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Mar 11, 2019

Landed in 8f93c08

@sam-github sam-github closed this Mar 11, 2019

@sam-github sam-github deleted the sam-github:check-for-invalid-chacha20-poly1305-iv-lengths branch Mar 11, 2019

sam-github added a commit that referenced this pull request Mar 11, 2019

crypto: check for invalid chacha20-poly1305 IVs
IV lengths of 13, 14, 15, and 16 are invalid, but are not checked by
OpenSSL. IV lengths of 17 or greater are also invalid, but they
were already checked by OpenSSL.

See:
- openssl/openssl@f426625
- https://www.openssl.org/news/secadv/20190306.txt

PR-URL: #26537
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BridgeAR added a commit that referenced this pull request Mar 13, 2019

crypto: check for invalid chacha20-poly1305 IVs
IV lengths of 13, 14, 15, and 16 are invalid, but are not checked by
OpenSSL. IV lengths of 17 or greater are also invalid, but they
were already checked by OpenSSL.

See:
- openssl/openssl@f426625
- https://www.openssl.org/news/secadv/20190306.txt

PR-URL: #26537
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

crypto: check for invalid chacha20-poly1305 IVs
IV lengths of 13, 14, 15, and 16 are invalid, but are not checked by
OpenSSL. IV lengths of 17 or greater are also invalid, but they
were already checked by OpenSSL.

See:
- openssl/openssl@f426625
- https://www.openssl.org/news/secadv/20190306.txt

PR-URL: #26537
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.