Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit "Using git-node" section of Guide #26580

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Mar 11, 2019

Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
Show resolved Hide resolved COLLABORATOR_GUIDE.md Outdated
@danbev

danbev approved these changes Mar 11, 2019

Update COLLABORATOR_GUIDE.md
Co-Authored-By: Trott <rtrott@gmail.com>

@vsemozhetbyt vsemozhetbyt added the meta label Mar 11, 2019

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Landed in 2e2670a

@Trott Trott closed this Mar 11, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 11, 2019

doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

PR-URL: nodejs#26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BridgeAR added a commit that referenced this pull request Mar 13, 2019

doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

PR-URL: #26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BridgeAR added a commit that referenced this pull request Mar 14, 2019

doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

PR-URL: #26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Apr 16, 2019

doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

PR-URL: #26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@BethGriggs BethGriggs referenced this pull request May 1, 2019

Merged

v10.16.0 proposal #27514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.