Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: replace deprecated and eliminate var in buffer-from.js #26585

Closed
wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

commented Mar 11, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

A possible problem with this change: Benchmarks are used to compare multiple versions of node to track performance. Since let in a for loop incurs a performance penalty in Node.js 6 and earlier, this will artificially show a performance increase in more recent versions of Node.js that is actually a performance increase in the use of let in a for loop and not a performance increase due to improvements in Buffer.from().

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

A possible problem with this change: Benchmarks are used to compare multiple versions of node to track performance. Since let in a for loop incurs a performance penalty in Node.js 6 and earlier, this will artificially show a performance increase in more recent versions of Node.js that is actually a performance increase in the use of let in a for loop and not a performance increase due to improvements in Buffer.from().

(On the other hand, I don't know that anyone is actually benchmarking 6 much these days. Although it does continue to show up in the charts at https://benchmarking.nodejs.org/ so maybe?)

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

^^^^^ Not blocking from me, but something for reviewers to consider.

@danbev
danbev approved these changes Mar 12, 2019
@danbev

This comment has been minimized.

@gengjiawen gengjiawen referenced this pull request Mar 21, 2019
1 of 2 tasks complete
@danbev

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Re-run of failing node-test-commit-arm (✔️)

@danbev

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Landed in 11f8024.

@danbev danbev closed this Mar 21, 2019

danbev added a commit that referenced this pull request Mar 21, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: nodejs#26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: nodejs#26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: nodejs#26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Mar 27, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos referenced this pull request Mar 27, 2019
BethGriggs added a commit that referenced this pull request Apr 17, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
MylesBorins added a commit that referenced this pull request May 16, 2019
benchmark: replace deprecated and eliminate var in buffer-from.js
PR-URL: #26585
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.