Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: remove dns.promises experimental warning #26592

Merged
merged 3 commits into from Mar 29, 2019

Conversation

Projects
None yet
9 participants
@cjihrig
Copy link
Contributor

cjihrig commented Mar 11, 2019

In a similar spirit to #26581.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@devsnek

This comment has been minimized.

Copy link
Member

devsnek commented Mar 11, 2019

i have a similar concern here.

as long as x.promises existing doesn't block x/promises from existing this is probably fine.

@vsemozhetbyt vsemozhetbyt referenced this pull request Mar 11, 2019

Open

Preparation for Node.js 12 #417

4 of 6 tasks complete
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Mar 11, 2019

Same question as in the other PR: This leaves it as experimental in the docs. That's intentional? (I'd prefer we make it stable in the docs and label this semver-major but that's just me!)

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Mar 11, 2019

Perhaps it's time just to take it out of experimental?

@targos

This comment has been minimized.

Copy link
Member

targos commented Mar 11, 2019

Did we get feedback or reported usage ?

@addaleax
Copy link
Member

addaleax left a comment

Like @jdalton suggested in the other PR, it probably makes sense to make this enumerable as well

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 25, 2019

Ping @cjihrig

@cjihrig cjihrig force-pushed the cjihrig:dns-promises branch from 88895d7 to 3b898b5 Mar 27, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Mar 27, 2019

as long as x.promises existing doesn't block x/promises from existing this is probably fine.

It shouldn't block it.

This leaves it as experimental in the docs.

I've add a semver major commit to address it.

Perhaps it's time just to take it out of experimental?

Agreed. It's been ~9 months with no significant issues.

Did we get feedback or reported usage ?

Not that I'm aware of.

it probably makes sense to make this enumerable as well

Done.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Mar 27, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Mar 29, 2019

This requires @nodejs/tsc review because it's semver major. (@addaleax you may want to re-review).

@mcollina
Copy link
Member

mcollina left a comment

LGTM

@targos

targos approved these changes Mar 29, 2019

cjihrig added some commits Mar 11, 2019

dns: remove dns.promises experimental warning
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
dns: make dns.promises enumerable
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
doc: move dns.promises to stable status
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@cjihrig cjihrig force-pushed the cjihrig:dns-promises branch from 3b898b5 to d8c2803 Mar 29, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Mar 29, 2019

Landed in 415a825...d8c2803. Thanks for the reviews.

@cjihrig cjihrig closed this Mar 29, 2019

@cjihrig cjihrig deleted the cjihrig:dns-promises branch Mar 29, 2019

@cjihrig cjihrig merged commit d8c2803 into nodejs:master Mar 29, 2019

@addaleax addaleax referenced this pull request Mar 30, 2019

Closed

fs: remove experimental warning for fs.promises #26581

2 of 2 tasks complete
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Apr 2, 2019

@cjihrig Sorry, I missed that you had labelled this semver-major. Is there any particular reason? I’d prefer to remove the label.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Apr 2, 2019

@addaleax because of the change in enumerability. I was being overly cautious, and would also be fine dropping the label.

@addaleax addaleax removed the semver-major label Apr 2, 2019

BethGriggs added a commit that referenced this pull request Apr 5, 2019

dns: remove dns.promises experimental warning
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs added a commit that referenced this pull request Apr 5, 2019

dns: make dns.promises enumerable
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs added a commit that referenced this pull request Apr 5, 2019

doc: move dns.promises to stable status
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

BethGriggs added a commit that referenced this pull request Apr 8, 2019

dns: remove dns.promises experimental warning
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Apr 8, 2019

dns: make dns.promises enumerable
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Apr 8, 2019

doc: move dns.promises to stable status
PR-URL: #26592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@BethGriggs BethGriggs referenced this pull request Apr 9, 2019

Merged

v11.14.0 proposal #27163

BethGriggs added a commit that referenced this pull request Apr 10, 2019

2019-04-10, Version 11.14.0 (Current)
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163

BethGriggs added a commit that referenced this pull request Apr 11, 2019

2019-04-11, Version 11.14.0 (Current)
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163

BethGriggs added a commit that referenced this pull request Apr 11, 2019

2019-04-11, Version 11.14.0 (Current)
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.