Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Note of options.stdio into child_process #26604

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@koh110
Copy link
Contributor

koh110 commented Mar 12, 2019

add Note of options.stdio into child_process.

Ref: #22892 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@koh110

This comment has been minimized.

Copy link
Contributor Author

koh110 commented Mar 12, 2019

@addaleax @Trott @bzoz That is a continuation #22892. Would you approve it?

Show resolved Hide resolved doc/api/child_process.md Outdated

@koh110 koh110 force-pushed the koh110:doc branch from 9904765 to bc834ac Mar 12, 2019

@addaleax
Copy link
Member

addaleax left a comment

Thank you!

Show resolved Hide resolved doc/api/child_process.md Outdated

@koh110 koh110 force-pushed the koh110:doc branch from bc834ac to 28018ba Mar 12, 2019

@bzoz
Copy link
Contributor

bzoz left a comment

Passing file descriptors works fine on Windows, its just sockets that are not supported.

@koh110 koh110 force-pushed the koh110:doc branch from 28018ba to 9a02f64 Mar 12, 2019

@koh110

This comment has been minimized.

Copy link
Contributor Author

koh110 commented Mar 12, 2019

I see. I think first sentence is better. I thought that file handle and file descriptors are slightly different.
So, I would change Passing sockets does not supported on Windows..
@addaleax @cjihrig @bzoz

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Mar 12, 2019

But in that case it’s probably not right to put it just under this particular type of option? Passing in a net.Socket object, rather than a file descriptor, is invalid on Windows too then, right?

@@ -637,7 +637,8 @@ pipes between the parent and child. The value is one of the following:
occurred).
6. Positive integer - The integer value is interpreted as a file descriptor
that is currently open in the parent process. It is shared with the child
process, similar to how {Stream} objects can be shared.
process, similar to how {Stream} objects can be shared. Passing sockets
does not supported on Windows.

This comment has been minimized.

Copy link
@Trott

Trott Mar 12, 2019

Member
Suggested change
does not supported on Windows.
is not supported on Windows.
@koh110

This comment has been minimized.

Copy link
Contributor Author

koh110 commented Mar 13, 2019

Windows allow named pipe. I think Passing in a net.Socket object is valid on Windows.
But I feel like that file descriptors might be intelligible phrase more than Passing sockets.
Umm...

It's valid on Windows.
https://github.com/nodejs/node/blob/master/test/common/index.js#L176-L181

require('net').createServer((conn) => {
    stdio: ['ignore', conn, 'ignore']
  });
}).listen(common.PIPE, () => {});

@koh110 koh110 force-pushed the koh110:doc branch from 9a02f64 to 6d78e01 Mar 13, 2019

@bzoz

bzoz approved these changes Mar 14, 2019

@koh110

This comment has been minimized.

Copy link
Contributor Author

koh110 commented Mar 15, 2019

I have no preference. How about this change? @addaleax @cjihrig

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Mar 19, 2019

Landed in e08ac04.

@danbev danbev closed this Mar 19, 2019

danbev added a commit that referenced this pull request Mar 19, 2019

doc: add Note of options.stdio into child_process
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

doc: add Note of options.stdio into child_process
PR-URL: nodejs#26604
Refs: nodejs#22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

doc: add Note of options.stdio into child_process
PR-URL: nodejs#26604
Refs: nodejs#22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

doc: add Note of options.stdio into child_process
PR-URL: nodejs#26604
Refs: nodejs#22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

targos added a commit that referenced this pull request Mar 27, 2019

doc: add Note of options.stdio into child_process
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

BethGriggs added a commit that referenced this pull request Apr 17, 2019

doc: add Note of options.stdio into child_process
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.