Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary semicolon after macro #26618

Closed
wants to merge 1 commit into
base: master
from

Conversation

@hashseed
Copy link
Member

hashseed commented Mar 12, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@hashseed hashseed requested a review from addaleax Mar 12, 2019

@hashseed

This comment has been minimized.

Copy link
Member Author

hashseed commented Mar 12, 2019

In fact, I'm getting some warnings in my GN build with the latest build configs from Chromium upstream, if the semicolon is there:

../../node/test/cctest/test_linked_binding.cc:19:60: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
NODE_MODULE_LINKED(cctest_linkedbinding, InitializeBinding);
@lpinca

lpinca approved these changes Mar 12, 2019

@addaleax

This comment has been minimized.

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

@antsmartian

This comment has been minimized.

Copy link
Contributor

antsmartian commented Mar 16, 2019

Landed in c5e619b 🎉 🎉

pull bot pushed a commit to SimenB/node that referenced this pull request Mar 16, 2019

test: remove unnecessary semicolon after macro
PR-URL: nodejs#26618
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

test: remove unnecessary semicolon after macro
PR-URL: nodejs#26618
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.