Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use EVPKeyPointer in more places #26632

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@bnoordhuis
Copy link
Member

bnoordhuis commented Mar 13, 2019

Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

Apologies, the diff is kind of hard to read in places. Might be easier side-to-side.

src: use EVPKeyPointer in more places
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!
@BridgeAR

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Mar 18, 2019

Landed in 3610155.

@danbev danbev closed this Mar 18, 2019

danbev added a commit that referenced this pull request Mar 18, 2019

src: use EVPKeyPointer in more places
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

PR-URL: #26632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

src: use EVPKeyPointer in more places
Rejoice, the code base is now free of manual EVP_PKEY_free() calls!

PR-URL: nodejs#26632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.