Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "crypto: add KeyObject.asymmetricKeySize" #26636

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@tniessen
Copy link
Member

tniessen commented Mar 13, 2019

This reverts commit 4895927 (#26387). While a similar API would be useful, I think the API should not have landed as it is, see #26631 and #26631 (comment).

Fixes: #26631

cc @nodejs/crypto

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Mar 13, 2019

@tniessen I just saw this. I'll back out the PR from the next release and add do not land tags until this is resolved.

@ryzokuken
Copy link
Member

ryzokuken left a comment

LGTM as the said method sets false expectations as discussed in the issue.

@Trott

Trott approved these changes Mar 14, 2019

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Mar 15, 2019

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Mar 15, 2019

Landed in 6f77af5.

@tniessen tniessen closed this Mar 15, 2019

tniessen added a commit that referenced this pull request Mar 15, 2019

Revert "crypto: add KeyObject.asymmetricKeySize"
This reverts commit 4895927.

PR-URL: #26636
Fixes: #26631
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

Revert "crypto: add KeyObject.asymmetricKeySize"
This reverts commit 4895927.

PR-URL: nodejs#26636
Fixes: nodejs#26631
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.