Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.x backport] process: move more dependency of environment variables to pre-execution #26662

Closed
wants to merge 4 commits into from

Conversation

Projects
4 participants
@refack
Copy link
Member

commented Mar 14, 2019

Backport of #26466

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@refack refack added the process label Mar 14, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@refack refack requested review from joyeecheung and BridgeAR Mar 14, 2019

@refack refack referenced this pull request Mar 14, 2019

Closed

lib: explicitly initialize debuglog during bootstrap #26468

2 of 2 tasks complete

@BridgeAR BridgeAR force-pushed the nodejs:v11.x-staging branch from f95e015 to 1fa5004 Mar 14, 2019

@joyeecheung joyeecheung referenced this pull request Mar 14, 2019

Closed

[v11.x] backport warning handler refactoring #26670

0 of 4 tasks complete

joyeecheung and others added some commits Mar 6, 2019

process: call `prepareMainThreadExecution` in `node inspect`
Since we should treat the node-inspect as third-party
user code.

PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
process: set up process warning handler in pre-execution
Since it depends on environment variables.

PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
process: handle process.env.NODE_V8_COVERAGE in pre-execution
Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.

PR-URL: #26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack force-pushed the refack:backport-26466-to-v11.x branch from 93795d9 to f442b54 Mar 17, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

process: call `prepareMainThreadExecution` in `node inspect`
Since we should treat the node-inspect as third-party
user code.

Backport-PR-URL: nodejs#26662
PR-URL: nodejs#26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

process: set up process warning handler in pre-execution
Since it depends on environment variables.

Backport-PR-URL: nodejs#26662
PR-URL: nodejs#26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

process: handle process.env.NODE_V8_COVERAGE in pre-execution
Since this depends on environment variable, and the worker threads
do not need to persist the variable value because they cannot
switch cwd.

Backport-PR-URL: nodejs#26662
PR-URL: nodejs#26466
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

process: move deprecation warning setup for --debug* args
PR-URL: nodejs#26662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Landed in v11.x-staging

@targos targos closed this Mar 27, 2019

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

@targos targos added this to Closed PRs in v11.x Mar 27, 2019

@refack refack deleted the refack:backport-26466-to-v11.x branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.